fix: remove tailwinds anti pattern in hero - Githubissues

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.

https://hot.opensauced.pizza

MIT License

426 stars 148 forks source link

fix: remove tailwinds anti pattern in hero #331

Closed AlexVCS closed 2 years ago

AlexVCS commented 2 years ago

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[✅ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

This PR is removing tailwinds anti-pattern in Hero.tsx (still in progress)

Related Tickets & Documents

Fixes #315

Mobile & Desktop Screenshots/Recordings

Screen Shot 2022-09-07 at 8 14 44 PM

Added tests?

[ ] 👍 yes
[✅ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[✅ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	4523630fbf725da24d623299f7b65b4e3226cbf1
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/631d13ce64dd3f0009985d7b
Deploy Preview	https://deploy-preview-331--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

AlexVCS commented 2 years ago

I've made a different PR, sorry I had some issues with my machine and older fork of the project.