open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

Feature: Loading Skeleton needed for the RepoWrap component. #357

Closed bdougie closed 2 years ago

bdougie commented 2 years ago

Type of feature

πŸ• Feature

Current behavior

While data is being fetched from the API, the footer is shown and looks awkward.

Screen Shot 2022-10-04 at 2 52 04 PM

note the footer is showing without scrolling. A skeleton will push this down.

Screen Shot 2022-10-04 at 2 49 52 PM

Suggested solution

Adding a loading skeleton similar to what we are doing in the HotRepoCard would be ideal.

Additional context

We are using react-loading-skeleton, please leverage that to completed this.

Code of Conduct

Contributing Docs

takanome-dev commented 2 years ago

.take

github-actions[bot] commented 2 years ago

Thanks for taking this on! If you have not already, join the conversation in our Discord

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.26.0-beta.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.26.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: