feat: organize voted repo list by week

nightknighto commented 2 years ago

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

In "My Votes" repo list, organizes it by weeks, specifically organizes it by This Week, Last Week & Older.

Related Tickets & Documents

closes #198

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	e7129cccdb2223f2458b45fe7c45e543d031d0e1
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/63693864a752320009a687c1
Deploy Preview	https://deploy-preview-393--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie commented 2 years ago

A few things while QA-ing this. I mistakenly missed that you were organizing this filtering based on the user's votes. Seeing this live confirms that this is not needed.

Currently, my votes show as older since I did not vote at all this week. This will be the majority of users, which is confusing when you do not have context that recent votes will be filter differently.

The ultimate goal is to filter the recent submissions into this week, last week, and older. This project is meant to show up and coming projects voted by the community.

Please update the following.

[ ] remove the filtering from myvotes
[ ] add filtering to the "recent" filter only.

As a user, I would like to see repositories recently submitted organized by week, and sorted by most voted.

bdougie commented 2 years ago

screenshot

This looks better. My recommendation is to not show the load more button unless there are more than one page of repos for the latest week.

Also, #394 will hopefully allow us to test adding to the list. The dev db does not get updates as frequent (i believe).

Browser metadata

``` Path: /recent?limit=35 Browser: Chrome 106.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 1000 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-393--hot-sauced-ui.netlify.app%2Frecent%3Flimit%3D35&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=106.0&resolution=1728x1000&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

nightknighto commented 2 years ago

@bdougie

I will make a quick temp fix for this, which will assume that the "This Week" and "Last Week" lists are not long, but the issue and PR I'm working on aren't focusing on the pagination and load more, so will be better to have them separate.

Realistically we will need new issues which will have to look into how limits and pages and "Load More" works, which would be responsible for making the correct "Load More" behavior for these lists if they are too long, would also handle not hiding the whole repo list when loading more, would not display "Load More" if there isnt more, and other enhancements that can be thought of.

bdougie commented 2 years ago

screenshot

This calendar shows on each filter. Can you remove it?

Browser metadata

``` Path: /recent Browser: Chrome 106.0.0.0 on Mac OS 10.15.7 Viewport: 1146 x 1336 @1x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-393--hot-sauced-ui.netlify.app%2Frecent&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=106.0&resolution=1146x1336&speed=1&start=true&ref=netlify-source)

Open Deploy Preview · Mark as Resolved

bdougie commented 2 years ago

@open-sauced/triage team please take a look as well.

I did notice that when viewing the page the data is not filtered right away. I need to click on another filter and then back to see the data filtered by week.

update:

link to video https://www.loom.com/share/e4849b2dc97949f0a7bbbccf8f64168d

nightknighto commented 2 years ago

This calendar shows on each filter. Can you remove it? Browser metadata

Open Deploy Preview · Mark as Resolved

solved

nightknighto commented 2 years ago

@open-sauced/triage team please take a look as well.

I did notice that when viewing the page the data is not filtered right away. I need to click on another filter and then back to see the data filtered by week.

update:

link to video https://www.loom.com/share/e4849b2dc97949f0a7bbbccf8f64168d

@bdougie fixed as well

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.27.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.27.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

open-sauced / hot