search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

Feature: submit new repo with shortcut #415

Closed NsdHSO closed 1 month ago

NsdHSO commented 1 year ago

Type of feature

🍕 Feature

Current behavior

If you want to submit a new repository for suggestions, you can't use shortcuts like cmd+enter/enter or escape to close the popup window

Suggested solution

Here is an example https://github.com/open-sauced/hot/blob/ecebb1ef0e85d46fb2fa67424081ae9250ff991e/src/components/Hero.tsx#L17-L44

Additional context

No response

Code of Conduct

Contributing Docs

takanome-dev commented 1 year ago

I saw that we have headlessui/react. I think it can handle that (accessibility included) and even for the hero search we can use headlessui combobox

NsdHSO commented 1 year ago

For the moment in this component we don't use headlessui combobox we use native input. I think if you want can you open a new issue, to see what the other colleagues say

0-vortex commented 1 year ago

I saw that we have headlessui/react. I think it can handle that (accessibility included) and even for the hero search we can use headlessui combobox

We do, we can also leverage radix components

For the moment in this component we don't use headlessui combobox we use native input. I think if you want can you open a new issue, to see what the other colleagues say

It does not make sense to complicate the current solution with keyboard accessibility when the baseline itself is not very accessible. I would agree the keyboard shortcut would be nice to have on top of an already accessible dropdown menu that displays some more information while typing and potential errors inline.

IMHO the UI components we have installed already could take care of a11y and enable this issue to be done, but it should at least mention improving the baseline! 🍕

takanome-dev commented 1 year ago

We do, we can also leverage radix components

Oh, didn't know about radix, it looks great :100:

IMHO the UI components we have installed already could take care of a11y and enable this issue to be done, but it should at least mention improving the baseline! pizza

Yeah using radix react dropdown will fix this issue :pizza:

Emmauel98 commented 1 year ago

How can I contribute to this?

bdougie commented 1 year ago

How can I contribute to this?

Do you have any suggestions or approach based on the existing conversation?