bug: downvoting a repo in myVotes list does not remove it from ui

[NsdHSO]

Describe the bug

If you are in MyVotes section and you press on the upvote/voted list from My voted Repository

Steps to reproduce

1. Go to the hot app
2. MyVotes section
3. Press upvote/voted
4. look in My voted Repository it still remains behind

Affected services

hot.opensauced.pizza

Platforms

Desktop

Browsers

Chrome

Environment

Production

Additional context

No response

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

Contributing Docs

• [X] I agree to follow this project's Contribution Docs

[0-vortex]

Do you mean after up or down voting, the repository remains in the list of voted repos? If so, you could adjust the title to something more relevant like "bug: downvoting a repo in myVotes list does not remove it from ui" 🍕

[NsdHSO]

Do you mean after up or down voting, the repository remains in the list of voted repos? If so, you could adjust the title to something more relevant like "bug: downvoting a repo in myVotes list does not remove it from ui" 🍕

yes, this is the issue, Tnx for your help.

[0-vortex]

@bdougie GFI?

[bdougie]

@bdougie GFI?

Not quite. This still needs more info and an attempt at a suggested solution. My guess is that the votes hooks need to refetch the votes when the button is clicked.

https://github.com/open-sauced/hot/blob/2d5bb0d9f694ea630030c56bc6c2985cf231e9b3/src/hooks/useVotedRepos.ts#L23

[rajat4984]

Is this issue resolved?

[Alexandre-Lustosa-Escossio]

I'll try to .take this one

[github-actions[bot]]

Thanks for taking this on! If you have not already, join the conversation in our Discord

[Alexandre-Lustosa-Escossio]

Since I didn't have any pictures of the issue I tried going straight to the site and reproducing it. It turns out I'm not able to upvote any repository from any page. With further investigation, I found that the post call when I upvote/downvote a repo is returning 409 and apparently it's a problem in the database's schema so It might be nothing wrong with the code. Could someone help me understand if I'm going in the right direction?

[takanome-dev]

After you upvote or downvote a repo, the voted repos should be refetched and the UI updated.

But I think there is an issue in the API we need to address. See https://github.com/open-sauced/api/issues/122

Feel free to give it a try and let us know how it goes :slightly_smiling_face:

[Alexandre-Lustosa-Escossio]

Hey guys, since my time is short and I can't tackle the backend issues that avoid me from solving this one I'll leave this one open for someone who has more free time!

[JDGuillaume]

Updated post to reflect additional insight.

Would love to .take this one. New to open source, but I've worked with React previously.

Based on the traffic listed in the Network tab, it appears that the page is essentially DDoSing the provided Supabase endpoint. On the initial payload, I'm observing approximately 112 requests to the database. Without interacting with the page, the number of requests to Supabase are continuing to grow.

As @bdougie suggested, I think that the useEffect dependency in the useVotedRepos component may be to blame. It's triggering an infinite rerender or so it appears.

[github-actions[bot]]

Thanks for taking this on! If you have not already, join the conversation in our Discord

[github-actions[bot]]

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.