open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

test(Hero): add e2e test for Hero component #433

Closed NsdHSO closed 1 year ago

NsdHSO commented 1 year ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Fixes #414

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit d675a88a0f72833b1bdc6161f17bf73bfa2485ef
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/63b3dc20904f7e0008d4af43
Deploy Preview https://deploy-preview-433--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

0-vortex commented 1 year ago

@NsdHSO we are using playwright ..

takanome-dev commented 1 year ago

@NsdHSO we are using playwright ..

@0-vortex should I also use playwright for #422 ? On the issue, it's mentioned to use cypress...

0-vortex commented 1 year ago

@NsdHSO we are using playwright ..

@0-vortex should I also use playwright for #422 ?

On the issue, it's mentioned to use cypress...

Sorry for the confusion; Before closing #395 we were caling end to end testing "cypress" because that's what we believed would be the most robust and end up being used, however we ended up going implementing playwright.

If your ticket mentions cypress but only writing a test, while cypress is in reality missing, that would imply there is another issue requiring the initial implememtation of cypress. Asking a question to remove any confusion prior to doing any work is the golden path, as it would hint to the error being that playwright is misspelled as cypress.

If the ticket itself would not be a misstype we would have 2 end to end testing frameworks, and even tho writing tests for both is almost identical, it would confuse a lot of people and double the maintenance cost in that area.

That is why whenever anything related to end 2 end testing is mentioned, it means playwright πŸ•