open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

test(Hero): add e2e test for Hero component #434

Closed NsdHSO closed 1 year ago

NsdHSO commented 1 year ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Fixes #414

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 770b37453ed7e06d266a422708aae88f3caa5189
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/63f49c5cdf86ac00070701a0
Deploy Preview https://deploy-preview-434--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

NsdHSO commented 1 year ago

I don't know why CI is failing, because on localhost work good image

NsdHSO commented 1 year ago

@0-vortex I think the scope of this issue, is only to check the accessibility, but no worries I can parse all your request. Please can you be more clear about what means absolute URLs? These? { "/popular": "popular", "/upvoted": "upvoted", "/discussed": "discussed", "/recent": "recent", "/myVotes": "myVotes", }

NsdHSO commented 1 year ago

Hi please @0-vortex can you provide me more info about your comment?