open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

Bug: Mobile view - when signed in, 'my votes' background wraps unexpectedly #438

Closed Themesses closed 1 year ago

Themesses commented 1 year ago

Describe the bug

When signed in, 'my votes' is added to the nav below the hero. When clicked, the text-wrap of the menu item is causing the background color to wrap unexpectedly as well. IMG_8FFC0F13F480-1

Steps to reproduce

  1. Main page on mobile ( width < 466px)
  2. Sign in with Github
  3. Menu below hero
  4. Click on 'my votes'

Affected services

hot.opensauced.pizza

Platforms

Mobile

Browsers

Chrome

Environment

Production

Additional context

No response

Code of Conduct

Contributing Docs

takanome-dev commented 1 year ago

Nice catch @Themesses πŸ‘ Can assign you if you want to take it πŸ•

Themesses commented 1 year ago

.take

Themesses commented 1 year ago

thanks @TAKANOME-DEV ☺️

0-vortex commented 1 year ago

My suggestion would be to wrap the links on 2 rows, but doing so might require some flex classes changed, what do you think?

The menu could definitely use some love, feel free to open improvement idea issues if you have thoughts! πŸ• ❀️

Themesses commented 1 year ago

There is definitely a point where it should wrap. I'll play around and follow up.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.31.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.31.0-beta.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.31.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: