feat: Close search pop-up when escape is pressed

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.

https://hot.opensauced.pizza

MIT License

418 stars 145 forks source link

feat: Close search pop-up when escape is pressed #445

Closed RozzaysRed closed 1 year ago

RozzaysRed commented 1 year ago

Utilize headless ui combobox as command palette

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

This PR replaces the existing input with headless ui's combobox and closes the search results when pressing esc.

Related Tickets & Documents

Fixes #418

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	36a832b83dbdf61d3560de4e556646ff156875c3
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/64636c7020ae900008629bc2
Deploy Preview	https://deploy-preview-445--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

takanome-dev commented 1 year ago

@RozzaysRed Headless ui combobox support keyboard navigation. Wondering why it's not working here :thinking:

RozzaysRed commented 1 year ago

@RozzaysRed Headless ui combobox support keyboard navigation. Wondering why it's not working here :thinking:

@TAKANOME-DEV i see what you me. Ill look in to why that is.

bdougie commented 1 year ago

Please provide a Desktop Screenshots/Recordings

takanome-dev commented 1 year ago

Works for me. I did not quite understand if @takanome-dev was presenting a reason to block this, but if so I will hold off on merging for a bit.

It was about a11y. It's all good now :pizza:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.31.0-beta.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket: