search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

chore: Bump *almost* all packages ⚡ #460

Closed Pranav-yadav closed 1 year ago

Pranav-yadav commented 1 year ago

What type of PR is this? (check all applicable)

Description

This PR bumps the almost all packages.

Related Tickets & Documents

NA

Mobile & Desktop Screenshots/Recordings

NA

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

IWantRegularUpdatesUpdateMeGIF

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui failed.

Name Link
Latest commit a5a078b4db9d63b3db29c110c6b6d2f1bcd1778e
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/641f649a6988c40008d361b4
0-vortex commented 1 year ago

Hello and thank you for a brave first contribution, making changes to the npm lock file is always an adventure. There are some potential blockers you might encounter in shipping this:

  1. this PR is using lockfileVesion=2 while .npmrc enforces version 3
  2. npm shrinkwrap is needed for predictability, this PR is removing it right now
  3. the typescript major upgrade has known breaking changes that would have to be addressed, adding technical debt to this PR

Would be very happy to pass this if it deals with 1 and 2 and would only upgrade non-major versions. For that purpose would use something like https://www.npmjs.com/package/npm-check-updates in interactive mode, going one step at a time or without any majors 🍕

Pranav-yadav commented 1 year ago

Hey @0-vortex 👋

Thanks for initial review.

I'm kind of having difficulty w/ npm ci as well as npm install. Below is the error:

![image](https://user-images.githubusercontent.com/55224033/227743751-96722b55-a7a3-4074-9e81-02df60ca0dad.png)

Whereas the package.json specifies:

  "engines": {
    "node": ">= 16.7.0",
    "npm": ">= 8.0.0"
  },

WDYT? what might be the reason? Or am I missing something?

0-vortex commented 1 year ago

Hey @0-vortex 👋

Thanks for initial review.

I'm kind of having difficulty w/ npm ci as well as npm install. Below is the error:

WDYT what might be the reason? Or am I missing something?

The squuosh cli is unmaintained for a while and only supports v16 of nodejs, that's one reason I forgot to mention in the above list :<

Would not go into upgrading packages as the project is in maintenance mode right now, unlike https://github.com/open-sauced/insights which is accepting papercuts! 🍕

Pranav-yadav commented 1 year ago

as the project is in maintenance mode right now.

Ohhh. I guess we should mention this in the top section of the README...

Thanks.

PS: Then how does the CI still passes on github (not this one, but generally..)? the npm ci/install run specifically... Just being curious. 🤔

Pranav-yadav commented 1 year ago

Closing this, as the Project is in Maintenance Mode. Note for Maintainers - do ping me in case these changes are required 👍

cc: @bdougie

0-vortex commented 1 year ago

as the project is in maintenance mode right now.

Ohhh.

I guess we should mention this in the top section of the README...

Thanks.

PS: Then how does the CI still passes on github (not this one, but generally..)? the npm ci/install run specifically... Just being curious. 🤔

They are still running with node16, dodging the message :D