open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

fix: make year dynamic in footer #462

Closed tmsagarofficial closed 1 year ago

tmsagarofficial commented 1 year ago

What type of PR is this? (check all applicable)

Description

Refers to issue #455 This PR tries to automatically update the year of the copyright section based on the current year

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 082160977f032fbbbe1c33c71754798d52b931cd
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/642929b81067470008d77e27
Deploy Preview https://deploy-preview-462--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tmsagarofficial commented 1 year ago

Pls check this PR now πŸ˜…

tmsagarofficial commented 1 year ago

This fixes desktop but not the mobile footer.

image

Will try to make it work on mobile too

Any Guidnce to me if u hav anything specific to this issue is really appreciated

0-vortex commented 1 year ago

This fixes desktop but not the mobile footer.

image

Will try to make it work on mobile too

Any Guidnce to me if u hav anything specific to this issue is really appreciated

Apply same procedure on line 153 - the footer is duplicated once for desktop and once for mobile! πŸ‘

NsdHSO commented 1 year ago

LGTM

tmsagarofficial commented 1 year ago

Any other changes required ? πŸ˜…

tmsagarofficial commented 1 year ago

@takanome-dev @0-vortex Pls review and let me know if there are any other changes πŸš€

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.31.0-beta.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.31.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: