search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 145 forks source link

fix: Footer position on initial render #474

Closed westernal closed 1 year ago

westernal commented 1 year ago

What type of PR is this? (check all applicable)

Description

There was a bug that when you opened the website the footer would change its position after few seconds and it was because there were no loading Skeleton on RecentRepoListWrap component and it was in ListRepositories component so I moved it to fix the issue.

Related Tickets & Documents

Fixes https://github.com/open-sauced/hot/issues/417

Mobile & Desktop Screenshots/Recordings

image

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 0fa13651de6037754fe3f823bcce27a0777077e7
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/64ac6d1f9231a90009dc03f8
Deploy Preview https://deploy-preview-474--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

westernal commented 1 year ago

Its my first contribution to open source projects, sorry in advance if its bad.

westernal commented 1 year ago

@westernal Tnx for your first contribution to this community. Nice PR, please can you run npm run-script lint ???

Sure, most lint problems are from my prettier extension on vscode I'll make sure I fix them.

westernal commented 1 year ago

@NsdHSO

westernal commented 1 year ago

Please merge this PR if it has no problem.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.33.1-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

westernal commented 1 year ago

@bdougie My pleasure.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.33.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: