fix: fixed nav menu button - Githubissues

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.

https://hot.opensauced.pizza

MIT License

418 stars 143 forks source link

fix: fixed nav menu button #483

Closed dev-phantom closed 1 year ago

dev-phantom commented 1 year ago

Description

fixed the nav button that was not displaying the nav menu

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Fixes #482

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	12dd719ad16b8f0edfd532b039ea66b26d3cb33d
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/64e29df1a0fe2f00072d360e
Deploy Preview	https://deploy-preview-483--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dev-phantom commented 1 year ago

looks like #477 has to be fixed before this can be tested

dev-phantom commented 1 year ago

npm run format

i ran it before there are currently no lint issues

bdougie commented 1 year ago

Can you add a before/after screenshot?

dev-phantom commented 1 year ago

Can you add a before/after screenshot?

I can't

Because of this issue https://github.com/open-sauced/hot/issues/477

takanome-dev commented 1 year ago

cc @bdougie

Before

https://github.com/open-sauced/hot/assets/79809121/4e30b751-beea-402a-9a4b-06fe2a76622d

After

https://github.com/open-sauced/hot/assets/79809121/78a8b85a-04a0-4b89-830f-8c6b342e448e

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.33.2-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 12 months ago

:tada: This PR is included in version 2.34.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: