open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 143 forks source link

fix: Search results that take too long no longer generate a white error page #503

Closed adnanjpg closed 5 months ago

adnanjpg commented 8 months ago

https://github.com/open-sauced/hot/issues/502

fix #502

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

502

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

no

[optional] What gif best describes this PR or how it makes you feel?

giphy

netlify[bot] commented 8 months ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 865e60908c42ce1408c4493e5f197a65b4044ecf
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/659842908c001a0008220257
Deploy Preview https://deploy-preview-503--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

adnanjpg commented 8 months ago

the current change implements the bare minimum to fix this problem, it just catches the error and shows an error message.

please let me know about the direction we should go in, should i submit this, or should we discuss a more permanent solution as the one I have suggested in the issue?

bdougie commented 5 months ago

Looks like this is not needed after https://github.com/open-sauced/hot/pull/518 is merge.