fix: Pressing enter when searching no longer goes to about:blank

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.

https://hot.opensauced.pizza

MIT License

418 stars 143 forks source link

fix: Pressing enter when searching no longer goes to about:blank #504

Closed adnanjpg closed 4 months ago

adnanjpg commented 8 months ago

Description

this pr fixes #501

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

fixes #501

Mobile & Desktop Screenshots/Recordings

Steps to QA

try to press enter in the search repositories field, before the repos load

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 8 months ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	553a7d1d1c74a84e95a20950d327f338bb46725e
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/659847177416e7000a7f0b24
Deploy Preview	https://deploy-preview-504--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: Accessibility: Best Practices: SEO: PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

adnanjpg commented 8 months ago

one more thing around this issue, is that the user can't just navigate to a repository by just clicking on it in the result list, the user has to click on it to set it as selected then has to press enter on the field, should I work on a fix for that here or with a new issue & pr?

bdougie commented 5 months ago

@adnanjpg checking in here. Let us know if you are still around to work on this.