open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
418 stars 143 forks source link

Bug: Broken search #523

Closed bdougie closed 4 months ago

bdougie commented 4 months ago

Describe the bug

I broke search in my last release. It is failing on starCount, should be item.star_count

Screen Shot 2024-04-13 at 11 02 44 AM

Steps to reproduce

Search and hitenter

Do you have any images or screen captures?

No response

Code of Conduct

Contributing Docs

furqan-abid commented 4 months ago

.take

github-actions[bot] commented 4 months ago

Thanks for taking this on! If you have not already, join the conversation in our Discord

furqan-abid commented 4 months ago

before

https://github.com/open-sauced/hot/assets/88319306/13dc726c-be85-4efc-b346-19a9e780c2a3

furqan-abid commented 4 months ago

after

https://github.com/open-sauced/hot/assets/88319306/8b787f85-0362-42fb-83fe-7316e8b29ea9

blank screen issue fixed

bdougie commented 4 months ago

@furqan-abid your PR is not really fixing the the issue. I had two approaches I was considering

  1. Remove Search all together
  2. Search from the api.opensauced.pizza repos endpoint directly and remove the supabase hook.
furqan-abid commented 4 months ago

@bdougie Thanks for your input. could I temporarily comment it out if it's not essential?

bdougie commented 4 months ago

No need to comment. Code is stored in git history. You just remove all of the search input context.

furqan-abid commented 4 months ago

Got it, I'll remove the search input

furqan-abid commented 4 months ago

@bdougie search bar removed!

Screenshot 2024-04-14 at 9 57 45 PM
github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 2.37.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 2.37.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: