Closed asaki222 closed 5 months ago
Name | Link |
---|---|
Latest commit | 2ad7db6eac4cdce5338a28053a68ad2d90cae50d |
Latest deploy log | https://app.netlify.com/sites/sauced-intro/deploys/65a6e86f9aa7f20008dc6eae |
Deploy Preview | https://deploy-preview-108--sauced-intro.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @asaki222,
Thank you so much for the PR! 🙌
Before I review this, can you please:
- Include the checklist boxes in the issue within the "Description" as per request on the issue.
- Write more descriptive descriptions. For example: Adjusting heading based on the issue detail --> This PR adjusts headings by (what did you do here) and adds a blank line (more details). The description should be clear and detailed so that the reviewer/maintainer can understand the changes made in your PR just by reading it. This would save us time to review your PR.
- Complete the PR form. I see that you link the issue in the "Description". But please fill it in the "Related Tickets & Documents" section and use "fixes" prefix (e.g.: fixes #000) to refer to the issue. You can read this resource to know more about it. FYI, many projects have this section on their PR forms. So you want to habitually fill in the form properly.
Please let me know if you have any questions. Thanks!
I updated the pr description! Let me know if I need to make any additional changes
Description
Adjusted subheadings to the right level in the Types of contributions chapter.
Put a blank line before and after each heading if needed to abide by headings best practice in Markdown
[X] Change below lines from h3 to h4 https://github.com/open-sauced/intro/blob/c2aca413850ac85bf400ff1c346dba18943dbe39/07-types-of-contributions.md?plain=1#L19
[X] Change below lines from h4 to h5 https://github.com/open-sauced/intro/blob/c2aca413850ac85bf400ff1c346dba18943dbe39/07-types-of-contributions.md?plain=1#L29
[X] Make sure that there is one blank line before and after each heading. For example: https://github.com/open-sauced/intro/blob/c2aca413850ac85bf400ff1c346dba18943dbe39/07-types-of-contributions.md?plain=1#L17-L20
This should be:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #107
Mobile & Desktop Screenshots/Recordings
Updated 'How to Contribute to Documentation Heading'
Updated 'Ways to use Blogging as a Open Source Contribution'
Updated 'Examples of documentation contributions'
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?