Closed CBID2 closed 5 months ago
Hey @CBID2 can you link to the file and the line you're talking about?
Also, please include more info on pizza-verse as we discussed.
Hey @CBID2 can you link to the file and the line you're talking about?
Also, please include more info on pizza-verse as we discussed.
Made the changes @BekahHW.
Can you link to the file in the repo you want them to change rather than in the intro.OpenSauced.pizza site please?
Can you link to the file in the repo you want them to change rather than in the intro.OpenSauced.pizza site please?
Done @BekahHW
Let's make this more optional. Instead of suggesting:
Turn "Congratulations on your first contribution! 🎉" into "Yay you made it! 🎉" Now, you're ready for next contribution: Head on over to the pizza-verse repo and repeat the exact steps to make your contribution to this repository.
Let's do this
"Congratulations on your first contribution! 🎉 If you're ready for your next contribution, head on over to the pizza-verse repo and follow the contribution guidelines for your next contribution. Once you're done, head on over to chapter five in this course."
Let's make this more optional. Instead of suggesting:
Turn "Congratulations on your first contribution! 🎉" into "Yay you made it! 🎉" Now, you're ready for next contribution: Head on over to the pizza-verse repo and repeat the exact steps to make your contribution to this repository.
Let's do this
"Congratulations on your first contribution! 🎉 If you're ready for your next contribution, head on over to the pizza-verse repo and follow the contribution guidelines for your next contribution. Once you're done, head on over to chapter five in this course."
Good idea! :)
@CBID2 as this is a good first issue, can you please point both suggestions to the file and code snippet that need to be changed by creating a permalink? This would make easier for first-time contributors to go to the exact file and line of codes.
See issue #107 for example.
@CBID2 I'd say, instead of:
- Add yourself to the guestbook. Here’s how: Do
run contributors:add
in your terminal.Follow the instructions to add yourself to the guestbook. After you finish and click enter, you must click enter again to confirm your choices.
Let's go with this:
- Add yourself to the guestbook with the CLI tool:
Then remove:
There are two ways you can complete this activity:
- Using the CLI tool.
- Manually editing the .all-contributorsrc file.
Although adding yourself to the guestbook with the CLI tool is simpler, we recommend manually editing the file to get more experience adding and committing your changes, creating pull requests, and pull request reviews. Below, you'll find the directions for each method:
CLI Tool
@CBID2 I'd say, instead of:
- Add yourself to the guestbook. Here’s how: Do
run contributors:add
in your terminal.Follow the instructions to add yourself to the guestbook. After you finish and click enter, you must click enter again to confirm your choices.
Let's go with this:
- Add yourself to the guestbook with the CLI tool:
Then remove:
There are two ways you can complete this activity:
- Using the CLI tool.
- Manually editing the .all-contributorsrc file.
Although adding yourself to the guestbook with the CLI tool is simpler, we recommend manually editing the file to get more experience adding and committing your changes, creating pull requests, and pull request reviews. Below, you'll find the directions for each method: CLI Tool
Done @adiati98
@CBID2 I'd say, instead of:
- Add yourself to the guestbook. Here’s how: Do
run contributors:add
in your terminal.Follow the instructions to add yourself to the guestbook. After you finish and click enter, you must click enter again to confirm your choices.
Let's go with this:
- Add yourself to the guestbook with the CLI tool:
Then remove:
There are two ways you can complete this activity:
- Using the CLI tool.
- Manually editing the .all-contributorsrc file.
Although adding yourself to the guestbook with the CLI tool is simpler, we recommend manually editing the file to get more experience adding and committing your changes, creating pull requests, and pull request reviews. Below, you'll find the directions for each method: CLI Tool
Done @adiati98
You haven't added the part that needs to be removed, @CBID2.
@CBID2 I'd say, instead of:
- Add yourself to the guestbook. Here’s how: Do
run contributors:add
in your terminal.Follow the instructions to add yourself to the guestbook. After you finish and click enter, you must click enter again to confirm your choices.
Let's go with this:
- Add yourself to the guestbook with the CLI tool:
Then remove:
There are two ways you can complete this activity:
- Using the CLI tool.
- Manually editing the .all-contributorsrc file.
Although adding yourself to the guestbook with the CLI tool is simpler, we recommend manually editing the file to get more experience adding and committing your changes, creating pull requests, and pull request reviews. Below, you'll find the directions for each method: CLI Tool
Done @adiati98
You haven't added the part that needs to be removed, @CBID2.
I mentioned it in the second checkbox (it says “Delete the following information”). The lines are a permalink @adiati98
@CBID2 that means we haven't removed the manual instruction.
There are two parts to be deleted:
Looking closely to the instruction, I think step 9 and 10 also needs to be adjusted.
Can you please double check to what else need to be done here? In the meantime, I add the needs triage
label until this is finalized. Thanks!
When you're updating the info Ayu suggested, please update this link https://github.localhost/github.com/open-sauced/pizza-verse
as well. It should be https://github.com/open-sauced/pizza-verse
.
@CBID2 that means we haven't removed the manual instruction.
There are two parts to be deleted:
- Paragraphs that need to be adjusted. https://github.com/open-sauced/intro/blob/4577a767191b640d3092b61a2c687c864fe96356/05-how-to-contribute-to-open-source.md?plain=1#L149-L156
- Manual instruction https://github.com/open-sauced/intro/blob/4577a767191b640d3092b61a2c687c864fe96356/05-how-to-contribute-to-open-source.md?plain=1#L162-L211
- Looking closely to the instruction, I think step 9 and 10 also needs to be adjusted.
Can you please double check to what else need to be done here? In the meantime, I add the
needs triage
label until this is finalized. Thanks!
Hi @adiati98 steps 9 and 10 definitely need to be revised.
Hi, I'm interested can i work on this issue?
Hi, I'm interested can i work on this issue?
Hi @nickaldwin. I'm doing a better version of this issue, so I'm going to close this one. Be on the lookout for it.
Type of feature
🍕 Feature
Current behavior
For the activity in the Let's Get Practical section, there has been two recurring themes:
npm run contributors:add
andnpm run contributors:generate
commands to generate their profile in the guestbook.After discussing this with @adiati98 and @BekahHW, we've come to the realization that giving contributors the option to either use the CLI tool or doing it manual is causing this confusion.
We also noticed that people are not contributing to the pizza-verse repo in spite of our promotion efforts, making it difficult for us to achieve OpenSauced's goal to create a contribution pathway for people to grow in their open source journey.
Suggested solution
For the first part of the issue, we having the following solution:
[ ] Go the "Manual Selection" section in step 5.
[ ] Delete the directions:
https://github.com/open-sauced/intro/blob/4577a767191b640d3092b61a2c687c864fe96356/05-how-to-contribute-to-open-source.md?plain=1#L162-L211
[ ] Go to step 6: https://github.com/open-sauced/intro/blob/4577a767191b640d3092b61a2c687c864fe96356/05-how-to-contribute-to-open-source.md?plain=1#L147
[ ] Replace it with the following statement:
6. Add yourself to the guestbook with the CLI tool
[ ] Go to the next paragraph and delete it: https://github.com/open-sauced/intro/blob/4577a767191b640d3092b61a2c687c864fe96356/05-how-to-contribute-to-open-source.md?plain=1#L149-L156
For the second half of the issue, do the following to add a section about our pizza-verse repo in the Let's Practical Section:
If you're ready for your next contribution, head on over to the [pizza-verse repo](https://github.com/open-sauced/pizza-verse) and follow the contribution guidelines for your next contribution. Once you're done, head on over to chapter 6 in this course.
Additional context
No response
Code of Conduct
Contributing Docs