search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

Delete redundant text content #123

Closed Pondy007 closed 4 months ago

Pondy007 commented 4 months ago

Description

This PR fixes the bug https://github.com/open-sauced/intro/issues/122

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes https://github.com/open-sauced/intro/issues/122

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Please provide some steps for the reviewer to test your change. If you have wrote tests, you can mention that here instead.

  1. Click a link
  2. See there is no replicated text at the end

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Proud of my first contribution. Hope I did not forget something. image

netlify[bot] commented 4 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit df5fabf5e8987b7c3b4fa956b27446c92857e5a4
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65d75ba4047da50008e87c43
Deploy Preview https://deploy-preview-123--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 4 months ago

Hi @Pondy007. I closed your Pull Request because it was not assigned to you yet. Please reread our contribution guidelines before submitting a pull request.

Pondy007 commented 4 months ago

Hi @CBID2 , Thanks for the assignment ! You are right, one should be assigned before working on it. (My english is not as good as my french...) Noted for next time ;-)

Pondy007 commented 4 months ago

Hi @CBID2 , What should I do now concerning this PR ? As I am the author, I cannot approve change (which is normal). Thank you.

Pondy007 commented 4 months ago

Hi @adiati98 , You are absolutely right ! I realized afterwards that I did my changes on main branch. (Beginner's mistake...) I will do what you suggested. Thx.