search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

Upd feat 120 #124

Closed Pondy007 closed 4 months ago

Pondy007 commented 4 months ago

Description

This PR fixes the feature #120.

Solution implemented : In the Getting Started subsection, I did the following:

  1. Run npm run contributors: add in your terminal. Follow the instructions to add yourself to the guestbook. After you finish and click enter, you must click enter again to confirm your choices
Lines 149 to 156 in [4577a76](https://github.com/open-sauced/intro/commit/4577a767191b640d3092b61a2c687c864fe96356)

 There are two ways you can complete this activity: 

 - Using the CLI tool. 
 - Manually editing the `.all-contributorsrc` file. 

 Although adding yourself to the guestbook with the CLI tool is simpler, we recommend manually editing the file to get more experience adding and committing your changes, creating pull requests, and pull request reviews. Below, you'll find the directions for each method: 

 **CLI Tool**
  1. Run git log to check if your changes have been automatically committed. Here's what you should expect to see as your commit message:

docs: add @your_username as a contributor

Then, press Q to run the log.

Congratulations on your first contribution! 🎉 If you're ready for your next contribution, head on over to the pizza-verse repo and follow the contribution guidelines for your next contribution. Once you're done, head on over to chapter 6 in this course.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #120

Mobile & Desktop Screenshots/Recordings

image image

Steps to QA

  1. Go to the Let's get practical section
  2. In the Getting Started subsection, check steps 6 to 11
  3. Check the last sentence of this section

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

😊

netlify[bot] commented 4 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 737501346f70b0b26b2e88331e25ed212658fc7a
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65dca13024162a0008a3205e
Deploy Preview https://deploy-preview-124--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Pondy007 commented 4 months ago

Hi, I made all requested changes. I still did not find how to allow some indentation in VSCode when saving. So I modified through github and it's ok now (and get the file to VSCode with proper indentation). New preview is the following.

image

adiati98 commented 4 months ago

I still did not find how to allow some indentation in VSCode when saving.

This mostly happens because there's a Markdown extension or feature enabled in your VS Code, which is good.

One trick that helps is when you need to indent a line for one tab, click tab 2 times, then save it. It will save the correct format of the indentation.

But there are some cases where this trick won't work, for example when creating directory tree in Markdown. In this case, commit and push the changes without saving it.

Hope this helps 😊

Pondy007 commented 4 months ago

Thanks a lot @adiati98 for your advices. I did not know the use of Resolve button. And for the tips ;-) Thanks both of you @adiati98 and @CBID2 for your time and review ! It really was a first good issue ! Have a nice day !