open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

[Feat #112] Add gif in Let's Get Practical subsection #126

Closed Pondy007 closed 4 months ago

Pondy007 commented 4 months ago

Description

This PR :

  1. Implement #112 :
    • modified: 05-how-to-contribute-to-open-source.md
    • new file: images/cli-tool.gif
    • Record and add a gif to show the output of the command "npm run contributors:add" in subsection Let's Get Practical, step 6
  2. Remove the extra space between "contributors:" and "add" in step 6

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #112

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Happy to contribute ! image

netlify[bot] commented 4 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 63211343f7b684fb19c7c91d29fef0c8a191a896
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65e36fc2459a38000804d1f1
Deploy Preview https://deploy-preview-126--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Pondy007 commented 4 months ago

Hi @CBID2 ! You are absolutely right. Thanks for your suggestion ! Best regards and have a nice day !

Pondy007 commented 4 months ago

Hi @adiati98 , I updated the gif as suggested. Let me know if it's ok for you. Best regards and have a nice day / week-end !

adiati98 commented 4 months ago

Well done, @Pondy007! 👏🏽 Thank you so much for your contributions. ✨

FYI, I've edited the related issue to be "Closes" instead of "Feat" so it will automatically close the issue once the PR is merged. GitHub only receives particular words for this feature. You can read more about it on the official GitHub docs. 😊

go time gif

CBID2 commented 4 months ago

Yay great job team! 😊

Pondy007 commented 4 months ago

@adiati98 Thank you for the approval, and the tip for next time I request a PR. So much to learn ! Thanks all for your advice, and your time to explain explicitly what should be done to improve and different links. image