search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
495 stars 96 forks source link

Added a note to fill PR form in lesson 05 #141

Closed Haimantika closed 3 months ago

Haimantika commented 3 months ago

Description

This solves issue https://github.com/open-sauced/intro/issues/140 , where I added a note to fill PR form in lesson 05

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes https://github.com/open-sauced/intro/issues/140

Mobile & Desktop Screenshots/Recordings

NA

Steps to QA

NA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 3 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 18f3b1f0df876a42074e47990831f77035ce19db
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/660076dc764fe800083ceb65
Deploy Preview https://deploy-preview-141--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 3 months ago

Hey @Haimantika. Can you add Closes next to the issue number in the Related Tickets and Documents section?

adiati98 commented 3 months ago

@Haimantika I think your PR here consists the previous commits from your changes on PR #133.

Can you please update your working branch (fix_lesson_5) by pulliing and merging the main from upstream? Thank you.

EDIT: I've updated your branch. You can pull it to your local by running the command git pull. :)

Haimantika commented 3 months ago

git pull

Oh thanks, so nothing pending from my end, right?

Haimantika commented 3 months ago

Hi @Haimantika, Thank you for your PR! 🙌

I left a review here for you to fix before we can approve your PR. I also updated your branch. So, can you please pull your branch before working on the fix?

Let me know when it's fixed and ready for a review. Thank you. 🙂

Accepted changes.