Closed adiati98 closed 3 months ago
hey @adiati98, I've made a PR could u review it https://github.com/open-sauced/intro/pull/150
@hx4nn you should be assigned the issue before creating a PR. You can use the .take
command to self-assign.
.take
Hey @hx4nn You've been assigned to issue #146.
And as stated in the important note on this issue, contributors may only take one good first issue.
That been said, I'll unassign you from this issue.
Thanks π
.take
Type of feature
π Documentation
Current behavior
We've noticed that some contributors made their changes directly on the
main
branch.Suggested solution
We want to make clear that changes are made on new branch and not directly on the
main
branch.[ ] Add step 4 in the "Setup the Project Locally" section in the CONTRIBUTING file with copy as follow:
Replace "YOUR-BRANCH-NAME" with a descriptive name for your branch β for example,
feat/add-submit-button
.[ ] Change number 4 to 5.
The code is located here:
https://github.com/open-sauced/intro/blob/c3c863688ef04649a2190332db97250867f03137/CONTRIBUTING.md?plain=1#L33-L39
Additional context
No response
Code of Conduct
Contributing Docs