search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
539 stars 110 forks source link

feat: create Portuguese folder #34

Closed CBID2 closed 1 year ago

CBID2 commented 1 year ago

Description

This PR adds a folder where the course files will be translated into Portuguese.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes #16

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit beb509b8da30b03705e908333b6fb0940d725135
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/64d8213ccba11d00086186f2
Deploy Preview https://deploy-preview-34--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

antonio-pedro99 commented 1 year ago

Hi @CBID2, thanks for this PR. But I do not think this is the way to go. Creating a pt-br folder under the root dir won't make the course to be scalable. It is not like we are just translating to pt-br, we should be able to start this translation in a way that translation to other language should be easy. Right now, if we just create a folder for each translation in the root dir, we would have lot of folders there.

CBID2 commented 1 year ago

Hi @CBID2, thanks for this PR.

But I do not think this is the way to go.

Creating a pt-br folder under the root dir won't make the course to be scalable. It is not like we are just translating to pt-br, we should be able to start this translation in a way that translation to other language should be easy.

Right now, if we just create a folder for each translation in the root dir, we would have lot of folders there.

I see @antonio-pedro99. What do you suggest I change?

antonio-pedro99 commented 1 year ago

I did something like this image

Hi @CBID2, thanks for this PR. But I do not think this is the way to go. Creating a pt-br folder under the root dir won't make the course to be scalable. It is not like we are just translating to pt-br, we should be able to start this translation in a way that translation to other language should be easy. Right now, if we just create a folder for each translation in the root dir, we would have lot of folders there.

I see @antonio-pedro99. What do you suggest I change?

antonio-pedro99 commented 1 year ago

We also need to clear few things

  1. First, how we are going to show the readers that the course is available in other idioms, for now I am doing like this:
Welcome to the Intro to Open Source Course with OpenSauced! This course is designed to provide you with an introduction to open source and guide you through the process of contributing to open source projects. 

## Language Support

- [Portuguese](./translations/pt-br/README.pt.md)
  1. AFAIK, we can only provide one sidebar in the index.html, which will be persistent to all other subpages. How can we tackle this?
CBID2 commented 1 year ago

I did something like this image

Hi @CBID2, thanks for this PR. But I do not think this is the way to go. Creating a pt-br folder under the root dir won't make the course to be scalable. It is not like we are just translating to pt-br, we should be able to start this translation in a way that translation to other language should be easy. Right now, if we just create a folder for each translation in the root dir, we would have lot of folders there.

I see @antonio-pedro99. What do you suggest I change?

@antonio-pedro99, I changed the folder structure.

CBID2 commented 1 year ago

We also need to clear few things

  1. First, how we are going to show the readers that the course is available in other idioms, for now I am doing like this:
Welcome to the Intro to Open Source Course with OpenSauced! This course is designed to provide you with an introduction to open source and guide you through the process of contributing to open source projects. 

## Language Support

- [Portuguese](./translations/pt-br/README.pt.md)
  1. AFAIK, we can only provide one sidebar in the index.html, which will be persistent to all other subpages. How can we tackle this?

Since we're only focusing on one language, this information to the Readme would be the best option for now @antonio-pedro99.

antonio-pedro99 commented 1 year ago

@CBID2 good. I have created these files in my fork xD. I don't have write permission to your fork, so I can not add changes directly to this branch. Instead, I have forked the repo from your branch and made the required changes. I was in a process of creating a new PR with your initial changes.

CBID2 commented 1 year ago

@CBID2 good.

I have created these files in my fork xD.

I don't have write permission to your fork, so I can not add changes directly to this branch. Instead, I have forked the repo from your branch and made the required changes.

I was in a process of creating a new PR with your initial changes.

Oh sorry @antonio-pedro99 lol