Closed antonio-pedro99 closed 3 months ago
Name | Link |
---|---|
Latest commit | 701d84c6d58f6c006946caf7188f967cbf2c87e6 |
Latest deploy log | https://app.netlify.com/sites/sauced-intro/deploys/65f19594468e9600080b7a85 |
Deploy Preview | https://deploy-preview-35--sauced-intro.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@CBID2 take a look at this. I am going incremental, not adding empty files to the PR.
Okay @antonio-pedro99, so should I close my PR?
@CBID2 take a look at this. I am going incremental, not adding empty files to the PR.
Also, hereβs how to put someone elseβs commit to your branch: https://tighten.com/insights/adding-commits-to-a-pull-request/
@CBID2 take a look at this. I am going incremental, not adding empty files to the PR.
Also, hereβs how to put someone elseβs commit to your branch: https://tighten.com/insights/adding-commits-to-a-pull-request/
Thanks for that. It seems that you did not checked allow edit from mantainers
hahah. I was trying this, but getting permission errors.
Okay @antonio-pedro99, so should I close my PR?
Let's work with one.
Okay @antonio-pedro99, so should I close my PR?
Let's work with one.
Turns out you had editing permission on my PR @antonio-pedro99
Okay @antonio-pedro99, so should I close my PR?
Let's work with one.
Turns out you had editing permission on my PR @antonio-pedro99
Sorry for that. Any way, you can add commits here if you see some nits
Okay @antonio-pedro99, so should I close my PR?
Let's work with one.
Turns out you had editing permission on my PR @antonio-pedro99
Sorry for that. Any way, you can add commits here if you see some nits
Hey @antonio-pedro99. I forked your repo but I do not have permission to add my commits. Can you grant me permission please?
Sure, I see you are getting the same issue. Let me see what I can do.
Sure, I see you are getting the same issue. Let me see what I can do.
It worked @antonio-pedro99. By the way, I just did the translation for the "Como Contribuir Para Open Source". Now, they did not have Angolan Portuguese in Google Translate so feel free to make it necessary to suit your dialect. :)
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
Okay
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
What files are empty again @antonio-pedro99?
@CBID2 One more thing, I was checking some[1] repos that support translations, many of them do not translate the file names, so I renamed the file back to English.
[1] CNCF Glossary
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
What files are empty again @antonio-pedro99?
Some of them were empty, I deleted them. I will add them as long as I am translating them.
@CBID2 One more thing, I was checking some[1] repos that support translations, many of them do not translate the file names, so I renamed the file back to English.
[1] CNCF Glossary
Interesting π€
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
What files are empty again @antonio-pedro99?
Some of them were empty, I deleted them. I will add them as long as I am translating them.
@antonio-pedro99, is this the reference?
Hi @CBID2, let's go incrementally. IMHO, we should not add empty files to the PR.
What files are empty again @antonio-pedro99?
Some of them were empty, I deleted them. I will add them as long as I am translating them.
@antonio-pedro99, is this the reference?
Not quite, this would be the reference. BTW, I think adding this file is good idea to invite more people to add other idioms support.
Is this ready to review now @antonio-pedro99?
Is this ready to review now @antonio-pedro99?
No, it's not! I will make it ready when it is fine.
Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:
I think all you need to do now is put the sidebar and navbar files into the translation/pt-br
folder as I did with Geoffrey in the French version. That's how we got it to work.
Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:
- translating the file names into Portuguese
- Adding a Portuguese version of the sidebar
- Revise hyperlink of the course directions
- Add a Brazilian flag emoji to the sidebar
I think all you need to do now is put the sidebar and navbar files into the
translation/pt-br
folder as I did with Geoffrey in the French version. That's how we got it to work.
Hi Chriss Thanks for letting me know I will take a look during the week ou next week. I been kind busy here.
Hey, @antonio-pedro99! :) How are you? :) I made some additions to your pull request:
- translating the file names into Portuguese
- Adding a Portuguese version of the sidebar
- Revise hyperlink of the course directions
- Add a Brazilian flag emoji to the sidebar
I think all you need to do now is put the sidebar and navbar files into the
translation/pt-br
folder as I did with Geoffrey in the French version. That's how we got it to work.Hi Chriss Thanks for letting me know I will take a look during the week ou next week. I been kind busy here.
Hi @antonio-pedro99! :) The French translation got merged so I tried pulling it to your PR, but disaster struck and a git rebase
occurred. π€¦πΎββοΈ So, I re-uploaded the Portuguese files, and things became great again! π I've managed to create a separate sidebar and navbar in Portuguese. The only problem now is this:
and this:
I'm going to try and work on that part tomorrow.
Hi @CBID2
I do not think we need this
If we already have this
Can you @antonio-pedro99 send me an invitation?
Or @CBID2 can you update your intro fork on the branch feat-anto...pt-br
with these changes here ?
Then I can work on it
Can you @antonio-pedro99 send me an invitation? Or @CBID2 can you update your intro fork on the branch
feat-anto...pt-br
with these changes here ? Then I can work on it
Sure
Made the update @geoffreylgv
Made the update @geoffreylgv
Alright, thanks. @CBID2, for the English version, when adding the flag and linking the respective translations, we should put the correct link to the translation. Let's check the English version's Readme
Made the update @geoffreylgv
Alright, thanks. @CBID2, for the English version, when adding the flag and linking the respective translations, we should put the correct link to the translation. Let's check the English version's Readme
Ok
@geoffreylgv, turns out the Brazilian flag icon links to the French one when I click on it.
They look correct to me @geoffreylgv
Was talking about the url to the translation | pt-br
instead of fr
<kbd>[<img title="Portuguese Brazilian" alt="Portuguese Brazilian" src="https://cdn.statically.io/flags/br.svg" width="22">](/translations/pt-br/README.md)</kbd>
They look correct to me @geoffreylgv
Was talking about the url to the translation |
pt-br
instead offr
<kbd>[<img title="Portuguese Brazilian" alt="Portuguese Brazilian" src="https://cdn.statically.io/flags/br.svg" width="22">](/translations/pt-br/README.md)</kbd>
Ohhh ok. I thought you meant the sidebar @geoffreylgv
Fixed it @geoffreylgv
Fixed it @geoffreylgv
Yep, fantastic ππΎ
How to have all these changes from here to your fork into antonio/feat-pt-br
?
Fixed it @geoffreylgv
Hey @CBID2, thinking about something
On English version, we all know it's written in English, so we don't need any more the English flag on the README. It means, on each README, the active language doesn't need to be on the readme. How do you see it
Fixed it @geoffreylgv
Hey @CBID2, thinking about something
On English version, we all know it's written in English, so we don't need any more the English flag on the README. It means, on each README, the active language doesn't need to be on the readme. How do you see it
That makes sense. This could also apply to the other translations.
What's left to finish this pull request?
What's left to finish this pull request?
I'm not too sure. @antonio-pedro99, what do you think?
What's left to finish this pull request?
I'm not too sure. @antonio-pedro99, what do you think?
I think we need to fix the flag stuff only xD
@CBID2 there's a merge conflict can you take a look?
@Yagasaki7K feel free to review this translation and suggest changes
@CBID2 there's a merge conflict can you take a look?
I can't do it via the mobile app @antonio-pedro99. Can you fix it?
@CBID2 there's a merge conflict can you take a look?
I can't do it via the mobile app @antonio-pedro99. Can you fix it?
Using mobile as well.
I will fix late tonight
@CBID2 there's a merge conflict can you take a look?
I can't do it via the mobile app @antonio-pedro99. Can you fix it?
Using mobile as well.
I will fix late tonight
Hey @antonio-pedro99. I revised the merge conflicts, and made the other edits.
Looks Good To Me
Looks Good To Me
I agree! :) We just need to fix the flag issue in the sidebar.
Looks Good To Me
I agree! :) We just need to fix the flag issue in the sidebar.
Hey @antonio-pedro99. @trusktr from docsify.js helped us fix the sidebar.
Looks Good To Me
I agree! :) We just need to fix the flag issue in the sidebar.
Hey @antonio-pedro99. @trusktr from docsify.js helped us fix the sidebar.
Ready to gooo
Hey @BekahHW! We're finally ready for a review! :)
Description
This is a continuation of #34, adding a Portuguese translation(and fixing the French translation) of the course. Doing so makes the course accessible to Portuguese-speaking developers who want to contribute to open source projects.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #16 Closes #56
Mobile & Desktop Screenshots/Recordings
The first translation
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?