open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
539 stars 110 forks source link

Sub section to intro course #44

Closed Lymah123 closed 1 year ago

Lymah123 commented 1 year ago

This PR makes changes to the following:

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 year ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit efdf7ed9c9d11281a7e746d056c335ec3545e21d
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/651eaffbfa21170008c41ed3
Deploy Preview https://deploy-preview-44--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Lymah123 commented 1 year ago

Alright. Thank you!

Lymah123 commented 1 year ago

I have changed the file to md.

Lymah123 commented 1 year ago

Thanks so much @BekahHW, @CBID2 and @geoffreylgv

I am committed to addressing all the points that have been raised and making the necessary corrections.

Lymah123 commented 1 year ago

Thank you @CBID2 !

I have made the necessary corrections you've mentioned.

Lymah123 commented 1 year ago

Yes, I have seen those suggestions. I was wondering what could be the problem before I submitted the PR . Thank you so much! @CBID2 ! I appreciate it!

Lymah123 commented 1 year ago

@BekahHW, @CBID2 and @geoffreylgv

You can review again.

Thank you.

Lymah123 commented 1 year ago

Hi @CBID2! I have made the changes. Thank you.

Lymah123 commented 1 year ago

Hi @CBID2! I've worked on the suggestions.

BekahHW commented 1 year ago

@Lymah123 thanks for all your hard work on this. It's getting closer!

Lymah123 commented 1 year ago

Alight @BekahHW

Thank you!

Lymah123 commented 1 year ago

@BekahHW and @CBID2 . I have made necessary changes on your suggestions. Waiting for your feedback. Thank you!

Lymah123 commented 1 year ago

@CBID2 , I have made the changes.

geoffreylgv commented 1 year ago

@CBID2 , I have made the changes.

Good job @Lymah123, you're doing great.

Lymah123 commented 1 year ago

Thank you @geoffreylgv . I appreciate you.

Lymah123 commented 1 year ago

@BekahHW and @CBID2 .

I would like to know the status of my PR.

Thanks.

BekahHW commented 1 year ago

Hey @Lymah123 the OpenSauced team is doing a company retreat, so we'll respond by Monday.

Lymah123 commented 1 year ago

Alright.

Thank you @BekahHW .

Lymah123 commented 1 year ago

@BekahHW , I have made the changes.

Lymah123 commented 1 year ago

Alright. I will make the necessary corrections as suggested and look into the examples.

Thank you!

Lymah123 commented 1 year ago

Hi, @BekahHW. I have made correction to the suggestions. You can review.

BekahHW commented 1 year ago

Hey @Oguntunjiharlimatodunola, can you do a separate PR for the contributing guide that links to that particular issue? It's a lot easier to review and helps keep issues separated.

Lymah123 commented 1 year ago

Alright @BekahHW .

CBID2 commented 1 year ago

Hey @Lymah123. There are some merge conflicts on your branch. Can you fix this? If you need tips, check out this blog post

Lymah123 commented 1 year ago

Screenshot (1286) Hi @CBID2 and @BekahHW , I'm having issue resolving the conflicts, can you see from the screenshot? I couldn't click on the resolve conflicts. What would you suggest?

I have checked the blog post likewise Youtube videos nothing seems to work yet. I guess I am stuck, I need help on how to resolve the conflicts.

CBID2 commented 1 year ago

Screenshot (1286)

Hi @CBID2 and @BekahHW , I'm having issue resolving the conflicts, can you see from the screenshot? I couldn't click on the resolve conflicts.

What would you suggest?

I have checked the blog post likewise Youtube videos nothing seems to work yet. I guess I am stuck, I need help on how to resolve the conflicts.

Have you tried this tool @Lymah123: https://blog.kaleidoscope.app/2022/04/12/resolving-merge-conflicts-in-vscode-with-kaleidoscope/

Lymah123 commented 1 year ago

@CBID2 , I have been able to resolved the conflicts. Thank you!

CBID2 commented 1 year ago

Things look great now @BekahHW

BekahHW commented 1 year ago

@Lymah123 I made some updates in this PR. Can you merge this branch into what you have and then I'll go ahead and merge this in.

Lymah123 commented 1 year ago

@Lymah123 I made some updates in this PR. Can you merge this branch into what you have and then I'll go ahead and merge this in.

Alright @BekahHW .

Lymah123 commented 1 year ago

@BekahHW , Done!