search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
503 stars 96 forks source link

feat:add scroll-to-top #57

Closed vrun1208 closed 9 months ago

vrun1208 commented 9 months ago

Description

Added a ScrollToTop button in order to ensure better user experience!

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

2023-10-05

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 9 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 2fabfda97725c9db748b62d5be343aa500412e5f
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/651db237d7f4a100089dc709
Deploy Preview https://deploy-preview-57--sauced-intro.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 9 months ago

Thanks for contributing @vrun1208, but I'm not sure how it fits with the project. Can you explain?

vrun1208 commented 9 months ago

Thanks for contributing @vrun1208, but I'm not sure how it fits with the project. Can you explain?

Hi @CBID2, actually for desktop view it does not much needed but in mobile view there are long readings and unnecessary scrolling from bottom to top on same page while reading docs.

CBID2 commented 9 months ago

Thanks for contributing @vrun1208, but I'm not sure how it fits with the project. Can you explain?

Hi @CBID2, actually for desktop view it does not much needed but in mobile view there are long readings and unnecessary scrolling from bottom to top on same page while reading docs.

I'm still unsure @vrun1208.

CBID2 commented 9 months ago

Hi @vrun1208. After a having discussion with the team, we decided to not accept this contribution. While this feature is nice to have, the course is not too long to scroll at the moment, even on mobile. Additionally, our hamburger menu on the bottom also makes easier to navigate between sections on mobile. In future, please raise an issue, wait until it gets approved and assigned to you before making a pull request(link the issue to your PR form too).

vrun1208 commented 9 months ago

Hi @vrun1208. After a having discussion with the team, we decided to not accept this contribution. While this feature is nice to have, the course is not too long to scroll at the moment, even on mobile. Additionally, our hamburger menu on the bottom also makes easier to navigate between sections on mobile. In future, please raise an issue, wait until it gets approved and assigned to you before making a pull request(link the issue to your PR form too).

Yeah, That's okay!, I'll surely come up with a new issue soon🚀