search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

feat: add test button (DO NOT MERGE) #78

Closed CBID2 closed 8 months ago

CBID2 commented 8 months ago

Description

This is just a test to see if Michael's cheatsheet for the edit button works

What type of PR is this? (check all applicable)

Related Tickets & Documents

Relates to #75

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 8 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit 7edbd6f90f72f0d6a4ac2074b4d38ca75fd428f2
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/653fc50b3a8fdb00082e4843
Deploy Preview https://deploy-preview-78--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adiati98 commented 8 months ago

Hey @CBID2,

I've checked this out :)

CBID2 commented 8 months ago

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page — (Edit this page on GitHub 📝). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

adiati98 commented 8 months ago

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page — (Edit this page on GitHub 📝). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

We can try it first. If it doesn't work, then we can let it go 😊

CBID2 commented 8 months ago

Hey @CBID2,

I've checked this out :)

  • We want to make it the same/similar as the docs as below:

    edit page

    while now we're having this:

    edit on GitHub

    I'm not sure which icon we use at docs, but maybe we can make the text the same as docs, and put the icon on the left side?

  • When I click the link to edit on GitHub, it goes to the same page — (Edit this page on GitHub 📝). Is this intentional for testing purpose?

    When I click "Edit this page" on docs, it will open the edit page on GitHub. So we might want to link it this way.

    I also noticed, docs repo has a "docs" folder, which is in line with the docsify docs. I'm not quite sure if we should create a docs folder and move the content in the folder as well here.

@adiati98, thanks for the feedback. Yeah I meant to link it to the actual GitHub page. To the point about using the button design that's in the docs repo, I originally planned on using the extension docsify recommended but it's outdated: https://github.com/njleonzhang/docsify-edit-on-github/blob/master/README.md#

We can try it first. If it doesn't work, then we can let it go 😊

I tried it and it did not work lol 😂

adiati98 commented 8 months ago

@CBID2 lol 😆 Well, let's do it your way, then 😄 Just put the icon on the left side.

Maybe the pencil or pen icon looks similar? ✏️ 🖊

CBID2 commented 8 months ago

✏️

Made the change @adiati98. Here's how it looks: edit this page example

adiati98 commented 8 months ago

It looks much better, @CBID2!

As for the link, let's make it similar with our docs. If you click the "Edit this page" link, it will bring user to the editing page.

So we want to navigate to the edit page such as this one for the intro instead of the blob.

CBID2 commented 8 months ago

It looks much better, @CBID2!

As for the link, let's make it similar with our docs. If you click the "Edit this page" link, it will bring user to the editing page.

So we want to navigate to the edit page such as this one for the intro instead of the blob.

Hi @adiati98. I made the change! :) @BekahHW, I think this is how we should put the edit "buttons" for now and then come back to it in the future.

BekahHW commented 8 months ago

@CBID2 sounds good to me. Are you going to put that on all the pages?

CBID2 commented 8 months ago

@CBID2 sounds good to me. Are you going to put that on all the pages?

Yes @BekahHW

CBID2 commented 8 months ago

Hey @BekahHW. I made the changes on PR #75, so I closed this one.