search

open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

feat: adds a section about Merging Conflicts #84

Closed Lymah123 closed 8 months ago

Lymah123 commented 8 months ago

This PR

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #81

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 8 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit e50244d664f804f5d60eb33909d773e9827fabab
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/653967269c8e9000086e8553
Deploy Preview https://deploy-preview-84--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Lymah123 commented 8 months ago

@CBID2 and @BekahHW . I will be waiting for your reviews.

Thank you.

Lymah123 commented 8 months ago

Hi @Lymah123. Just gave you a comment

Okay @CBID2 , I will look into that.

Lymah123 commented 8 months ago

https://www.loom.com/share/171d34d2e18c48f4bb90b226770608a8

Hi @CBID2 , I am having issue with the markdown. Can you see what I am facing in the video clip?

CBID2 commented 8 months ago

https://www.loom.com/share/171d34d2e18c48f4bb90b226770608a8

Hi @CBID2 , I am having issue with the markdown. Can you see what I am facing in the video clip?

I think that's because you did not add a file name and end it with .md

Lymah123 commented 8 months ago

https://www.loom.com/share/171d34d2e18c48f4bb90b226770608a8 Hi @CBID2 , I am having issue with the markdown. Can you see what I am facing in the video clip?

I think that's because you did not add a file name and end it with .md

Wow! it worked. I forgot totally! Thank you @CBID2 !

Lymah123 commented 8 months ago

Hi @CBID2 , you can review again.

Thanks a lot.

BekahHW commented 8 months ago

Hey @Lymah123, when you have a minute, can you take a look at the docs for PRs ? There's some info there I think you'll find helpful on creating PRs.

Lymah123 commented 8 months ago

Hey @Lymah123, when you have a minute, can you take a look at the docs for PRs ? There's some info there I think you'll find helpful on creating PRs.

Alright. Thank you @BekahHW !

Lymah123 commented 8 months ago

Well done @Lymah123! :) I made some more edits to your PR's form. As you continue your open source journey, always fill out every section of the pull request form based on the commented instructions. It helps maintainers and others understand how to go about reviewing your contribution. For more tips, check out Writing Your First Pull Request: Tips, Best Practices, and AI-Powered Tools for Success

Noted!!! Thanks for always being patient with me @CBID2! I so much appreciate you.