Closed adiati98 closed 7 months ago
Name | Link |
---|---|
Latest commit | e8413d6d941d6bf8e1dbc2ce01824b039ffc34e5 |
Latest deploy log | https://app.netlify.com/sites/sauced-intro/deploys/65565582dc37a90007ce4441 |
Deploy Preview | https://deploy-preview-88--sauced-intro.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@adiati98 I didn't run it locally since you're still drafting, but you're definitely on the right track. This is a lot of great work.
@CBID2 I see that you've committed a revision. Thanks! 😊 I think if there's no other suggestions, this PR is ready to be merged.
Also, a friendly reminder that we do squash for merging in commits (I found this out not long ago myself 😁)
@CBID2 I see that you've committed a revision. Thanks! 😊 I think if there's no other suggestions, this PR is ready to be merged.
Also, a friendly reminder that we do squash for merging in commits (I found this out not long ago myself 😁)
We still need to solve this one @adiati98: https://github.com/open-sauced/intro/pull/88#discussion_r1394140390
@CBID2, the link opens several reviews. Is it the Community Translation one?
If so, I've adjusted the wordings for that section in this commit. Can you please recheck it?
About if we will have this section and markdown file, I think it's related to issue #71, which we can talk about it later.
But I don't mind if we postpone the merge until we're sure 😄
@CBID2, the link opens several reviews. Is it the Community Translation one?
If so, I've adjusted the wordings for that section in this commit. Can you please recheck it?
About if we will have this section and markdown file, I think it's related to issue #71, which we can talk about it later.
But I don't mind if we postpone the merge until we're sure 😄
Yeah you're correct @adiati98. We can talk about issue #71 later.
Description
This PR holds changes as follow:
Fixed unordered list.
Fixed Markdown for code blocks.
Fixed and adjusted headings.
Adjusted wordings across the docs.
Reorganized instructions.
Removed duplicate Markdown examples.
Changed examples with concrete examples based on our course.
Added a step to ensure the chapter's numbers are in order to "Adding a New Chapter" and "Adding New Chapters to the Sidebar" sections.
Changed the word "sections" to "chapters" for consistency.
Removed step 1 in the "Adding a New Chapter" section below as this repo doesn't have a docs folder
Added a section called "Working with the Content" to hold subsections below:
Added a pragraph in the "Issues" section about raising an issue and tagging maintainers for triage.
Changed "Go Live feature" with "Live Server extension" because after I did research, there is no feature called "Go Live" in VS Code.
Highlighted inline code for more clarity.
Added tree directory for the examples in "Adding Translations to Documentation" section.
Moved "Adding Translations to Documentation" to
i18n-guidelines.md
.Added "Translating the Intro to Open Source Course" section to link the
i18n-guidelines.md
.Organized "How Can I Contribute?" section in the
i18n-guidelines.md
.Live Preview
https://deploy-preview-88--sauced-intro.netlify.app/#/CONTRIBUTING
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #87
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?