open-sauced / intro

Empowering Your Open Source Journey: From First Contribution to Project Leadership
https://opensauced.pizza/learn
Other
497 stars 96 forks source link

docs: Fix and improve `CONTRIBUTING.md` and `i18n-guidelines.md` #88

Closed adiati98 closed 7 months ago

adiati98 commented 8 months ago

Description

This PR holds changes as follow:

Live Preview

https://deploy-preview-88--sauced-intro.netlify.app/#/CONTRIBUTING

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #87

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 8 months ago

Deploy Preview for sauced-intro ready!

Name Link
Latest commit e8413d6d941d6bf8e1dbc2ce01824b039ffc34e5
Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/65565582dc37a90007ce4441
Deploy Preview https://deploy-preview-88--sauced-intro.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BekahHW commented 8 months ago

@adiati98 I didn't run it locally since you're still drafting, but you're definitely on the right track. This is a lot of great work.

adiati98 commented 7 months ago

@CBID2 I see that you've committed a revision. Thanks! 😊 I think if there's no other suggestions, this PR is ready to be merged.

Also, a friendly reminder that we do squash for merging in commits (I found this out not long ago myself 😁)

CBID2 commented 7 months ago

@CBID2 I see that you've committed a revision. Thanks! 😊 I think if there's no other suggestions, this PR is ready to be merged.

Also, a friendly reminder that we do squash for merging in commits (I found this out not long ago myself 😁)

We still need to solve this one @adiati98: https://github.com/open-sauced/intro/pull/88#discussion_r1394140390

adiati98 commented 7 months ago

@CBID2, the link opens several reviews. Is it the Community Translation one?

If so, I've adjusted the wordings for that section in this commit. Can you please recheck it?

About if we will have this section and markdown file, I think it's related to issue #71, which we can talk about it later.

But I don't mind if we postpone the merge until we're sure 😄

CBID2 commented 7 months ago

@CBID2, the link opens several reviews. Is it the Community Translation one?

If so, I've adjusted the wordings for that section in this commit. Can you please recheck it?

About if we will have this section and markdown file, I think it's related to issue #71, which we can talk about it later.

But I don't mind if we postpone the merge until we're sure 😄

Yeah you're correct @adiati98. We can talk about issue #71 later.