search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 29 forks source link

feat: pin changelog when scrolling #200

Closed zeucapua closed 7 months ago

zeucapua commented 7 months ago

Description

When scrolling through /changelog, the title will become sticky until the entire changelog scrolls by.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Addresses #191

Mobile & Desktop Screenshots/Recordings

https://github.com/open-sauced/landing-page/assets/20603494/253e5709-1dc8-4fff-8a23-3c203ae15a00

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

sticky af

netlify[bot] commented 7 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit 4285327a6b564853cd859d11be1423a04a8c2b6b
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65c1624ddc0c6000088ebbb9
Deploy Preview https://deploy-preview-200--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

zeucapua commented 7 months ago

I tried the deploy preview and pulled it down locally, but it doesn't seem to stick as you scroll the changelog, in Chrome. I see it working in the video though. Maybe a commit wasn't pushed?

https://github.com/open-sauced/landing-page/assets/20603494/26034a9b-6e0f-4b4a-9d7d-416ed92e987a

Opening it up via the preview deploy works for me. It doesn't sticky if the content isn't expanded on the right since there isn't enough height to scroll through, but otherwise looks fine. Mind sending a video on how it looks for you?

nickytonline commented 7 months ago

I see it working now. I had the sections collapsed which is why it wasn't kicking in.