open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 29 forks source link

feat: add use cases menu #216

Closed zeucapua closed 6 months ago

zeucapua commented 6 months ago

Description

Adds a drop down menu that leads to various use cases pages

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #207

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-03-12 at 8 15 55 AM

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 6 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit efbe9b54b0138444a5dc81359806a7cbcb3d40e2
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65f07848489c0b0008d3c5a7
Deploy Preview https://deploy-preview-216--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline commented 6 months ago

Screenshot 2024-03-12 at 9 21 50 AM

Is there a /contributors page yet? Going there 404s for me in the deploy preview

The page appears to be there in code.

nickytonline commented 6 months ago

The menu is also not above the page contents.

CleanShot 2024-03-12 at 11 24 32

zeucapua commented 6 months ago

I think this branch some how has an upstream from earlier before I made the /contributors page, but it should work if merged into main since that has the page @nickytonline

isabensusan commented 6 months ago

+1 to /contributors page throwing a 404 (maybe the deploy preview hasn't updated yet) +1 to fixing the z-index for the dropdown to be above anything else

Mobile one more thing is we need to add the links to the mobile navigation -- we don't need to add the full dropdown here, I think just adding the links "Contributors" "Maintainers" "Teams" would be ok for mobile

image
nickytonline commented 6 months ago

I think this branch some how has an upstream from earlier before I made the /contributors page, but it should work if merged into main since that has the page @nickytonline

Merge latest from main just to be certain, but yeah.

jpmcb commented 6 months ago

Can you:

git checkout main
git pull main
git checkout feat/user-cases-dropdown
git rebase origin/main

to get this branch ontop of what's the latest on main?