search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 29 forks source link

feat: connect your github sounds better #218

Closed bdougie closed 5 months ago

bdougie commented 6 months ago

Description

Had an instance where I got to watch someone try to log into our app from the landing page and many questions came up. It is not clear what "connecting with github" means in the context of our landing page. I am swapping the with to your in this PR.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

before:

Screen Shot 2024-03-15 at 10 02 06 AM

after:

Screen Shot 2024-03-15 at 10 02 56 AM

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 6 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit e2109cbb298c703febde6e681d486f1e97dd4d39
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65f45665b77e380008a1c530
Deploy Preview https://deploy-preview-218--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

bdougie commented 6 months ago

There are extra changes in here. Looks like my prettier decided to work. I am going to roll with it, but we may want to consider aligning the lint rules with other projects.

https://github.com/open-sauced/landing-page/blob/main/.prettierrc.js#L5