search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 28 forks source link

fix: make "we are more than... green squares" slogan accessible #249

Closed CBID2 closed 2 months ago

CBID2 commented 4 months ago

Description

This PR is a new of #164

[!NOTE] Read the description section in pull request #164 for more context.

Mobile & Desktop Screenshots/Recordings

[!NOTE] There is no audio in the below video due to technical difficulties.

https://github.com/open-sauced/landing-page/assets/105683440/c56fd2ba-e537-41a9-8e28-1cf9c9efb1f9

Steps to QA

Tier (staff will fill in)

  • [ ] Tier 1
  • [ ] Tier 2
  • [ ] Tier 3
  • [ ] Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 4 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit 63bc22a68db4eaeaa5fcbe83116c83bf5072d96d
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/665ca21268cf4500083c3ad7
Deploy Preview https://deploy-preview-249--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 2 months ago

Hey @nickytonline or @bdougie, can this PR be merged?

nickytonline commented 2 months ago

Hey @nickytonline or @bdougie, can this PR be merged?

I'm not really understanding the title of this PR and how this addresses the accessibility issue reported.

I also can't find the page this is located on in the site. I don't think it's in the production site anymore, at least from navigating around. What page(s) can I go to to test this?

CBID2 commented 2 months ago

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

nickytonline commented 2 months ago

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

Which page(s) in the deploy preview can I test this on? I can't seem to find it and there's no QA instructions.

CBID2 commented 2 months ago

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

Which page(s) in the deploy preview can I test this on? I can't seem to find it and there's no QA instructions.

It used to be on the teams page in the website, but I think it went away.

nickytonline commented 2 months ago

As it doesn't seem to be used anywhere now, I'm going to go ahead and close this.