open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 28 forks source link

Changed typography on changelog to dark mode #254

Closed isabensusan closed 3 months ago

isabensusan commented 3 months ago

Description

Added prose-invert to the changelog body component to make typography dark mode, and removed previous hacky attempts at making text white.

Related Tickets & Documents

closes #256

Mobile & Desktop Screenshots/Recordings

Before: Very subtle, but there's links in the text that the user can't see because they are black by default.

image

After: links and text are visible because of default dark mode theme

image

Steps to QA

  1. Go to https://opensauced.pizza/changelog
  2. Open any changelog item and notice the text is fully readable now

Tier (staff will fill in)

[optional] Are there any post-deployment tasks we need to perform?

-

[optional] What gif best describes this PR or how it makes you feel?

tired-charles-barkley-gif-by-nba-on-tnt

netlify[bot] commented 3 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit 3bc62d63e223a2b124f1a34dbdb9532ead9fe8ba
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/663239b56f55da00084d6042
Deploy Preview https://deploy-preview-254--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline commented 3 months ago

There's some errors related to eslint. See https://app.netlify.com/sites/opensauced-landing/deploys/6630576edf5afe0008bc9070#L101-L634

bdougie commented 3 months ago

There's some errors related to eslint. See https://app.netlify.com/sites/opensauced-landing/deploys/6630576edf5afe0008bc9070#L101-L634

I looked into this and it was unrelated to this PR. Need to add aria tags to an img

https://github.com/open-sauced/landing-page/pull/257