search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 28 forks source link

Two subscribe forms on mobile landing page #270

Closed bdougie closed 3 months ago

bdougie commented 3 months ago

image

nickytonline commented 3 months ago

It happens on larger screens too. Removing this line fixes it, so maybe the conditional check isn't quite right.

https://github.com/open-sauced/landing-page/blob/bd0fdfca7e74f71353a9e79feecd76077e326956/components/common/layout/PageLayout.tsx#L49

Asin-Junior-Honore commented 3 months ago

@nickytonline I would love to fix this please🧑‍💻

nickytonline commented 3 months ago

@Asin-Junior-Honore, you're welcome to work on it. I'm just not positive if the line I mentioned should show the subscribe component in certain pages, or if it's included, does it double the subscribe form everywhere.

Deferring to @BekahHW or @chhristopher to see where the standalone subscribe form should be or can we just remove the line I mentioned completely?

Asin-Junior-Honore commented 3 months ago

Alright then I guess I would just wait for @BekahHW or @chhristopher to give a precise response before I proceed

bdougie commented 3 months ago

We can just go with removing the line @Asin-Junior-Honore

nickytonline commented 3 months ago

I've assigned the issue to you @Asin-Junior-Honore. Thanks for tackling this!

Asin-Junior-Honore commented 3 months ago

Hey 👋 @nickytonline , @bdougie I have just finish resolving the issue kindly review my pr thanks😊

nickytonline commented 3 months ago

Hey 👋

@nickytonline , @bdougie I have just finish resolving the issue kindly review my pr thanks😊

No need to ping us directly. The whole team gets GitHub notifications. 😎