search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
31 stars 29 forks source link

feat: add missing canonical tags #331

Closed CBID2 closed 2 months ago

CBID2 commented 3 months ago

Description

This PR adds a canonical tag for the blogs, improving its SEO.

Related Tickets & Documents

Closes #313

Mobile & Desktop Screenshots/Recordings

Steps to QA

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

Lets hope this works GIF

netlify[bot] commented 3 months ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit 6fbdf88679879fa8ab817fb2d43f4c39337a973e
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/6685a02afe51120009eb792e
Deploy Preview https://deploy-preview-331--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CBID2 commented 3 months ago

Hey @BekahHW! :) I made a draft PR for this issue. I hope it is what you had in mind.

BekahHW commented 3 months ago

@CBID2 we'll be merging in a PR before this that upgrades sanity studio, so let's wait until that gets merged in. You'll need to check each of the pages on the checklist to make sure they have the correct canonical_url. It looks like the blog posts are getting picked up, but there are other pages on the list. We can potentially break it into two issues though.

CBID2 commented 3 months ago

@CBID2 we'll be merging in a PR before this that upgrades sanity studio, so let's wait until that gets merged in. You'll need to check each of the pages on the checklist to make sure they have the correct canonical_url. It looks like the blog posts are getting picked up, but there are other pages on the list. We can potentially break it into two issues though.

Good idea @BekahHW. I think for the second part of this issue, having some sort of example on how to add the canonical link would help.

BekahHW commented 3 months ago

Good idea @BekahHW. I think for the second part of this issue, having some sort of example on how to add the canonical link would help.

If it were a good-first-issue, I would have an example. Taking a look at the codebase and checking documentation should lead you on the right path.

BekahHW commented 3 months ago

@CBID2 can you merge in the latest changes and give me an update on how the issues going when you get a chance?

CBID2 commented 3 months ago

@CBID2 can you merge in the latest changes and give me an update on how the issues going when you get a chance?

Hey @BekahHW. I just updated my branch with the latest changes. I'm currently working on my PR via Gitpod(I tried doing it locally but my computer runs slow when I do) and I get this message whenever I click on the Editing SEO Content link in the Readme Screenshot of error. According to Gitpod's Docs, it is recommended to Configure the port, but I'm a bit hesitant to do that as I don't want to mess up the main repo. What do you recommend?

BekahHW commented 3 months ago

I haven't used gitpod before. What other resources did you look at to navigate the issues you're having?

BekahHW commented 2 months ago

@CBID2 do you have an update here? I'd like to get the issue completed soon.

CBID2 commented 2 months ago

@CBID2 do you have an update here? I'd like to get the issue completed soon.

Hey @BekahHW. I tried finding another alternative but couldn't find one.😔

CBID2 commented 2 months ago

@CBID2 do you have an update here? I'd like to get the issue completed soon.

Seems like this method with Gitpod is the only one I can do: https://www.gitpod.io/docs/configure/workspaces/ports

CBID2 commented 2 months ago

Hey @BekahHW. I decided to close this PR. You can work on this issue