search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
32 stars 29 forks source link

Bug: Newsletter sign up no longer collects a user's email #336

Open nickytonline opened 3 months ago

nickytonline commented 3 months ago

While investigating a build error in the app, https://github.com/open-sauced/app/issues/3796, @netlify/plugin-nextjs@5 requires migration steps to support Netlify Forms. Refer to https://ntl.fyi/next-runtime-forms-migration for migration example., I discovered that our newsletter signup no longer collects emails in the app. I tried it out in the landing-page, and it's the same behviour, it no longer works.

The last one collected appears to have been in March, but a couple tests I did does not collect the emails.

We're using the pages router, but it appears we may need to do the same fix as suggested in the Netlify docs to be able to use Netlify Forms with Next.js. Not sure when this broke.

The fix is detailed at https://docs.netlify.com/frameworks/next-js/overview/#breaking-changes.

We haven't seen build failures in the landing-page project yet, but when we do, you'll need to add this environment variable to the project temporarily until this issue is fixed, and then remove the env var, once this issue is resolved.

CleanShot 2024-07-29 at 13 20 54

1Dedios commented 2 months ago

Hey, can I be assigned this bug?

jpmcb commented 2 months ago

Sorry, @1Dedios, this is a critical issue the core-team will have to tackle! Thanks for volunteering however!

jpmcb commented 2 months ago

Reopening - we'll want to revisit this and bring back the form since the fix in https://github.com/open-sauced/landing-page/pull/337 was more or less a quickfix.