search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
30 stars 29 forks source link

fix: Use button for Ghost.io newsletter signup #337

Closed jpmcb closed 1 month ago

jpmcb commented 1 month ago

Description

Related Tickets & Documents

Closes: https://github.com/open-sauced/landing-page/issues/336

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-08-08 at 12 31 54 PM

Steps to QA

  1. Run landing page locally via npm run dev
  2. Go to https://deploy-preview-337--opensauced-landing.netlify.app/maintainers, scroll to bottom
  3. See "Subscribe" button

Tier (staff will fill in)

netlify[bot] commented 1 month ago

Deploy Preview for opensauced-landing ready!

Name Link
Latest commit 5064b0a2eb9c68e05c9e03539e4f3876bc3389c8
Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/66b52df8e1fd9200089b6beb
Deploy Preview https://deploy-preview-337--opensauced-landing.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jpmcb commented 1 month ago

cc @nickytonline - this seemed to have goofed up abunch of the spacing (and looks to have used 4 spaces) for the components I touched. npm run lint doesn't do anything and eslint --fix components/sections/home-page/Newsletter.tsx doesn't do anything either.

Thoughts?

jpmcb commented 1 month ago

Any thoughts on fixing the spacing shenanigans I've created? ^ @open-sauced/engineering

nickytonline commented 1 month ago

Any thoughts on fixing the spacing shenanigans I've created? ^ @open-sauced/engineering

I formatted it on my local and pushed. Maybe it's some NeoVim wonkiness with this project in particular?

jpmcb commented 1 month ago

I formatted it on my local and pushed. Maybe it's some NeoVim wonkiness

It's probably because eslintrc.json is more or less empty and you're relying on VScode internal tooling while I need to use the common tooling under the scripts in package.json to ensure conformity.

https://github.com/open-sauced/landing-page/blob/1bdcdd2e4b618a8031b95d8176ace6427452a586/.eslintrc.json#L1-L6

We can merge this through and I'll bring forward an .eslintrc.json that conforms with the app and api.