search

open-sauced / landing-page

This is the new landing page for open sauced
https://opensauced.pizza
31 stars 29 forks source link

Bug: Improve lighthouse accessibility score. #87

Open bdougie opened 1 year ago

bdougie commented 1 year ago

Describe the bug

This was reported here.

Looks really cool, but doesn't feel like a website. Any reason why hyperlinks are marked up as

? Also, why do links that lead to a different page trigger a scroll up animation on the same page while page contents changes? It feels disorienting.

Looks like there are few places where we are doing Button or Link is rendering a <div href/>. Opening this issue for tracking reasons.

I have not yet triaged this myself, but we will want to make sure this site passes all accessibility tests now that it is live. This was an oversight on my part.

Steps to reproduce

Run the lighthouse on the site and report issues here. Depending on scope, we can open separate issues for fix in one PR.

Screen Shot 2022-12-14 at 9 34 22 AM

Affected services

opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

Contributing Docs

takanome-dev commented 1 year ago

All the buttons except the subscribe newsletter are divs with href.

I ran lighthouse on Firefox and Brave and it got pretty good score imh. Here are some screenshots:

Brave Desktop

opensauced_lighthouse_1

Brave Modile

opensauced_lighthouse_3

Firefox mobile

opensauced_lighthouse_2

Common for both on mobile

firefox_1 firefox_2 firefox_3 firefox_4 firefox_5 firefox_6

bdougie commented 1 year ago

I think the focus for this issue should be improving the accessibility score. If updating the links does not improve the score, we should avoid it. I am updating the title to reflect this.

CBID2 commented 1 year ago

@EmmaDawsonDev, I think you can share some great insights on this.

EmmaDawsonDev commented 1 year ago

Definitely happy to take a look and do an accessibility audit. I'd prioritise fixing the links/buttons over raising the lighthouse score as that's something critical for keyboard users to access the site and not something lighthouse can pick up. But I'm sure there's a lot of small tweaks that can make a big difference

dev-phantom commented 1 year ago

.take

github-actions[bot] commented 1 year ago

Thanks for taking this on! If you have not already, join the conversation in our Discord