Feature: Update the the NoteBox storybook stories

open-sauced / open-sauced

🍕 This is a project to identify your next open source contribution.

https://app.opensauced.pizza

MIT License

936 stars 994 forks source link

Feature: Update the the NoteBox storybook stories #1160

Closed bdougie closed 2 years ago

bdougie commented 3 years ago

Type of feature

Style

Current behavior

Link to the design story

Screen Shot 2021-09-22 at 2 21 34 PM

Desired solution

It should mirror what is live in production (note the below is dark mode).

Screen Shot 2021-09-22 at 2 12 02 PM

Additional context

Please ask questions if you are considering taking this on. #1159 is also related to this.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

bdougie commented 3 years ago

@mtfoley may have more context here

0xi4o commented 3 years ago

@bdougie @mtfoley Can I take a crack at this? I looked at #1159. The Basic Template button was changed to a SubtleLink. I just have to update the NoteCard story to reflect that change, right? Also SubtleLink's color in light mode is offWhite so it's barely visible. I can update that as well.

0-vortex commented 3 years ago

@ilangorajagopal we’d love to have your help! Take a look at our contribution docs, including the section that talks about how to assign yourself to the issue.

0xi4o commented 3 years ago

.take

github-actions[bot] commented 3 years ago

Thanks for taking this on! If you have not already, join the conversation in our Discord

mtfoley commented 3 years ago

@bdougie @mtfoley Can I take a crack at this? I looked at #1159. The Basic Template button was changed to a SubtleLink. I just have to update the NoteCard story to reflect that change, right? Also SubtleLink's color in light mode is offWhite so it's barely visible. I can update that as well.

great catch! We saw screenshots in dark mode so somehow we missed this.

mtfoley commented 3 years ago

@mtfoley may have more context here

I don’t have a lot to add other than:

in my understanding storybook is separately deployed right now so maintainers may need to help with that
I didn’t realize the note form was in storybook when I did the remirror pr so I may have actually broken that part locally
If it helps to refer to significant work on storybook was done in https://github.com/open-sauced/open-sauced/pull/1037

0xi4o commented 3 years ago

in my understanding storybook is separately deployed right now so maintainers may need to help with that

Got it. I'll create a WIP pull request along with some screenshots of the fix.

If it helps to refer to significant work on storybook was done in feat: Updating storybook #1037

I'll check that PR and see if there's anything relevant for this issue.

0xi4o commented 3 years ago

@mtfoley I've made the necessary changes.