search

open-sauced / opengraph

OpenGraph dot Open Sauced is a general purpose social card generator
https://opengraph.opensauced.pizza
MIT License
6 stars 4 forks source link

feat: Highlight Cards UI Generation (frontend-only) #36

Closed nightknighto closed 1 year ago

nightknighto commented 1 year ago

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

closes #35

Mobile & Desktop Screenshots/Recordings

101 102 103

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

nightknighto commented 1 year ago

@0-vortex fixed the lint issues & merge conflicts

bdougie commented 1 year ago

It is not clear what "frontend-only" means in the title. Can you clarify that?

Other than that, functionality of the card works. Also is there a test plan or steps to review or test the cards?

nightknighto commented 1 year ago

It is not clear what "frontend-only" means in the title. Can you clarify that?

Meaning that this PR is only responsible for only generating the cards, and not responsible for connecting to the backend or database.

Other than that, functionality of the card works. Also is there a test plan or steps to review or test the cards?

There are scripts to manually generate and test the social cards visually , test:local:user and test:local:highlight

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.1.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: