refactor: update social card design

open-sauced / opengraph

OpenGraph dot Open Sauced is a general purpose social card generator

https://opengraph.opensauced.pizza

MIT License

6 stars 4 forks source link

refactor: update social card design #52

Closed OgDev-01 closed 1 year ago

OgDev-01 commented 1 year ago

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[x] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

This PR updates the social card design

Related Tickets & Documents

closes #44

Mobile & Desktop Screenshots/Recordings

Insights Page

Users

Highlights

Added tests?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

brandonroberts commented 1 year ago

We should remove the padding in between languages also to keep consistent with GitHub PR images

bdougie commented 1 year ago

I'm thinking we might want to add the copy or previews text

isabensusan commented 1 year ago

I think it'd look better if we used bold titles instead of semi-bold, and grey for the subtitles (see screenshot), just to ensure a clear content hierarchy, but honestly it's a small detail and it still looks good the way it is right now.

brandonroberts commented 1 year ago

@OgDev-01 can we get this pushed through soon?

OgDev-01 commented 1 year ago

a quick question @bdougie, are we replacing the username with the highlights copy or adding the copy below the username on the highlights card?

bdougie commented 1 year ago

a quick question @bdougie, are we replacing the username with the highlights copy or adding the copy below the username on the highlights card?

Replace the user name.

OgDev-01 commented 1 year ago

Updated copy

cc: @bdougie @brandonroberts

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.2.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: