search

open-sauced / pizza-verse

A repository for all things pizza.
MIT License
38 stars 55 forks source link

Feature/add sisig pizza recipe #72

Closed nickaldwin closed 6 months ago

nickaldwin commented 6 months ago

Description

This PR adds a section about Sisig Pizza to the pizza-recipe.md file.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Relates to #32

Added to documentation?

[optional] What GIF best describes this PR or how it makes you feel?

😊

CBID2 commented 6 months ago

Hi @nickaldwin! :) Can you fill out the other sections of your Pull Request's form please? It'll make it easier for me to review your contribution. Consider using this Pull Request as an example.

nickaldwin commented 6 months ago

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

CBID2 commented 6 months ago

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

@nickaldwin, you haven't linked the issue that your PR addresses. It's done like this: Relates to #issue number This is the issue your pull request addresses

nickaldwin commented 6 months ago

Hi @CBID2 i update the PR form i apologize if i skip the comments thank you

@nickaldwin, you haven't linked the issue that your PR addresses. It's done like this: Relates to #issue number This is the issue your pull request addresses

oh i missed that one You're close @nickaldwin! 😁 Add Relates to next to the issue number. Keywords are important when linking issues in PRs. They automatically close the issue once a PR is merged.

i see it thanks 😁

nickaldwin commented 6 months ago

Hi @CBID2, I hope this is correct this time. I have updated the pull request description with related tickets and documents. This closes #72

CBID2 commented 6 months ago

Hi @CBID2, I hope this is correct this time. I have updated the pull request description with related tickets and documents. This closes #72

@nickaldwin, the description is good but the Related Tickets section is still incorrect.

CBID2 commented 6 months ago

@nickaldwin read the last paragraph in this issue: https://github.com/open-sauced/pizza-verse/issues/36 It's the one that corresponds to your PR.

nickaldwin commented 6 months ago

hi @CBID2 i figured it out i update the related and tickets & docs section

CBID2 commented 6 months ago

hi @CBID2 i figured it out i update the related and tickets & docs section

Alright, now we're getting somewhere @nickaldwin! :) Now, I can officially review your contribution

nickaldwin commented 6 months ago

@CBID2 thank you

nickaldwin commented 6 months ago

@CBID2 I should pay attention to details in things thank you so much for your advice.