search

open-sauced / pizza-verse

A repository for all things pizza.
MIT License
38 stars 55 forks source link

Chores: Replace the logo in this repo's README #79

Open adiati98 opened 3 months ago

adiati98 commented 3 months ago

[!IMPORTANT] If you've worked on a good first issue in any of our community repositories before, please refrain from taking this issue. We may remove you from the assignees and not accept your pull request if you choose to proceed.

Description

Below logo in this repo's README is the old one, we should replace it with the new one.

Screenshot 2024-05-02 103453

Suggested Solution

Replace the logo by changing the link in the src with the below:

https://github.com/open-sauced/assets/blob/main/logos/logo-on-dark.png

Line to be changed:

https://github.com/open-sauced/pizza-verse/blob/6a3137efa6dbfd0d91683d45e3ae814fb42ba262/README.md?plain=1#L3

adiati98 commented 3 months ago

This issue has been taken and still a work in progress. Refer to #80.

prw760 commented 3 months ago

My first open-source contrib. Thanks for the “good first issue” idea! :)

I forked the pizza-verse repository, added a branch, made the change, and commit/push to my forked repository. I then created a pull request.

Did I miss anything? Need a bit of mentorship here with the process. Thank you! :)

adiati98 commented 3 months ago

Hey @paulrwade,

Thanks for your interest in working on this! But as you can see in this comment, this issue has been taken. We only have a bit trouble in assigning the issue.

For you future reference:

That said, unfortunately, I'll have to close your PR because of duplication.

If you'd like, you can work on this one in our guestbook repository.

What you need to do is comment on it, and I'll assign it to you.

prw760 commented 3 months ago

Hi, Ayu.

I did read through the comments, but I must have misunderstood them. I saw that one contributor said he had fixed It #80. And I thought this was issue #79. Sorry about that.

I will close the Push Request right away -- and will look at the guestbook repository issue.

Thanks in advance for any additional mentoring you can provide.

-- Paul

Sent with Proton Mail secure email.

On Tuesday, May 7th, 2024 at 1:51 PM, Ayu Adiati @.***> wrote:

Hey @.***(https://github.com/paulrwade),

Thanks for your interest in working on this! But as you can see in this comment, this issue has been taken. We only have a bit trouble in assigning the issue.

For you future reference:

  • You might want to pay attention as well to the comment in each issue to understand about its progress.
  • Don't work on anything before you're assigned to an issue to prevent you from wasting the time and effort.

That said, unfortunately, I'll have to close your PR because of duplication.

If you'd like, you can work on this one in our guestbook repository.

What you need to do is comment on it, and I'll assign it to you.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

prw760 commented 3 months ago

Also, I commented on the guestbook logo issue. Hopefully, you can assign that one to me. Thanks.

adiati98 commented 3 months ago

[!NOTE] This issue is still open for grab. Please leave a comment and we will assign it to you. Don't work on anything before you're assigned to this issue.

prw760 commented 3 months ago

Will do. Thanks again! :)

On Fri, May 10, 2024 at 1:43 AM Ayu Adiati @.***> wrote:

Note

This issue is still open for grab. Please leave a comment and we will assign it to you. Don't work on anything before you're assigned to this issue.

— Reply to this email directly, view it on GitHub https://github.com/open-sauced/pizza-verse/issues/79#issuecomment-2104200671, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDDT3I5JNKNWQ77H4YLHS4LZBSCBVAVCNFSM6AAAAABHDIPSGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGIYDANRXGE . You are receiving this because you were mentioned.Message ID: @.***>

prw760 commented 3 months ago

Please assign this one to me. Thank you! :)

adiati98 commented 3 months ago

Please assign this one to me. Thank you! :)

Hey Paul,

Thank you for your interest in working on this issue. But as mentioned in the important section of this issue, we only assign one contributor to one good first issue throughout our community repository.

As you've taken a good first issue to fix the logo at guestbook repo, we unfortunately can't assign you to this issue.

The note here is for any new contributor who wants to work on this issue. 🙂

Feel free to check our repos and look for an issue that fits your interest!

prw760 commented 3 months ago

No worries at all. I had just seen your suggestion to do it in another earlier email -- but that was before I did the same change in the guestbook repo. Thanks -- I'll look through the pizza-verse repo for issues next. Sound good?

Sent with Proton Mail secure email.

On Friday, May 10th, 2024 at 1:00 PM, Ayu Adiati @.***> wrote:

Please assign this one to me. Thank you! :)

Hey Paul,

Thank you for your interest in working on this issue. But as mentioned in the important section of this issue, we only assign one contributor to one good first issue throughout our community repository.

As you've taken a good first issue to fix the logo at guestbook repo, we unfortunately can't assign you to this issue.

Feel free to check our repos and look for an issue that fits your interest!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>