open-sauced / pizza

This is an engine that sources git commits and turns them to insights
Apache License 2.0
31 stars 13 forks source link

Bug fix: Remove windows/freebsd/etc. from docker buildx platforms #27

Closed jpmcb closed 1 year ago

jpmcb commented 1 year ago

Description

This removes windows, freebsd, and a few other platforms from the list of platforms docker buildx builds against.

An error surfaced in the last run of the image release where one of the compile time byte types were mismatched. I didn't dig in too deep, but my guess is this is because the Go generated code for the different platforms has varying sizes for a few of the different platforms.

https://github.com/open-sauced/pizza/actions/runs/5616082794/job/15217697894

I'm not worried about building to anything besides linux and darwin. Removing those other bespoke platforms resulted in a passing build when running the following locally:

$ docker buildx bake \
    -f ./docker-bake.hcl \
    --set build.args.GO_LDFLAGS="$GO_LDFLAGS" \
    --set cross.tags=ghcr.io/open-sauced/pizza:test \
    cross

What type of PR is this? (check all applicable)

Related Tickets & Documents

N/a

Mobile & Desktop Screenshots/Recordings

N/a

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel