search

open-sauced / pizza

This is an engine that sources git commits and turns them to insights
Apache License 2.0
32 stars 13 forks source link

feat: github orgs for /bake #41

Open mtfoley opened 1 year ago

mtfoley commented 1 year ago

Description

Adds optional org and archives payload params to /bake endpoint. If an org is specified in the format "https://github.com/open-sauced", the server will perform a GET request to https://api.github.com/orgs/open-sauced/repos and leverage the returned JSON to generate a list of repository URLs to process. By default, it will skip the repos that are archived, but this can be changed by setting archives=true in POST to /bake.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Resolves #32

Mobile & Desktop Screenshots/Recordings

N/A

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

mtfoley commented 1 year ago

hey @jpmcb thank you very much for the feedback! I think I've addressed it and I added a couple more comments to what I've got so far.

mtfoley commented 1 year ago

the review can be held off until i fix some of these linter things

mtfoley commented 1 year ago

@jpmcb I think I have the lint issues fixed now, should be ready for a review.

jpmcb commented 1 year ago

Hi @mtfoley - any progress on this? Happy to help where I can!

mtfoley commented 1 year ago

@jpmcb Time has been fleeting lately. I've done some things with them but go routines and their trappings are definitely areas I could use some more practice with. Practical examples you know of re: buffered channels would help if you know of them. Thx for the bump!

jpmcb commented 1 year ago

Go by example has some good stuff and a pretty light overview of the entire Go paradigm: https://gobyexample.com/channel-buffering

And you can't go wrong with the standard library's documentation: https://pkg.go.dev/github.com/eapache/channels

Good luck!! Please feel free to tag me in specific bits of code you are wondering about