open-sauced / pizza

This is an engine that sources git commits and turns them to insights
Apache License 2.0
31 stars 13 forks source link

Feature: multi-arch builds with `make` and `docker buildx` #7

Closed jpmcb closed 1 year ago

jpmcb commented 1 year ago

Type of feature

🍕 Feature

Current behavior

Currently, the only architecture that is being built with make build is the one from the current users machine. I.e., when building images from my M1 Mac, it creates arm based images.

Suggested solution

We should support multi-arch image manifests so we can support running on either arm or x86.

Typically these days, this is done via docker buildx and has been pretty well documented at this point: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

Additional context

No response

Code of Conduct

Contributing Docs

tuananh commented 1 year ago

lemme submit a PR

jpmcb commented 1 year ago

closed by #10