search

open-sdg / open-sdg

A platform for collecting and disseminating data for the Sustainable Development Goal global indicators.
https://open-sdg.org
MIT License
62 stars 77 forks source link

Sources 7 and up not showing in Sources tab #2073

Closed Zelheim closed 5 months ago

Zelheim commented 12 months ago

Please complete the following information Site repository URL: https://github.com/sdg-data-canada-odd-donnees/sdg-data-donnees-odd and https://github.com/sdg-data-canada-odd-donnees/sdg-odd-dev Open SDG version: 2.2.0

Describe the bug When there are more than 6 sources for any given indicator, Source 7 and up do not show up in the Sources tab.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://sdg-data-canada-odd-donnees.github.io/sdg-odd-dev/1-4-1/
  2. Click on Sources
  3. Scroll down to the bottom of the tab
  4. See error

Expected behavior Source 7 and up should be showing up in the Sources tab

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

brockfanning commented 11 months ago

@Zelheim If you check out your metadataschema.yml file, you'll see that there are only entries for the source* fields going up to 6: https://github.com/sdg-data-canada-odd-donnees/sdg-data-donnees-odd/blob/develop/metadata_schema.yml

In order to display up to 8, you'll need to add entries in this file for 7 and 8. I think you can just duplicate the entries for 6 and then change "_6" to "_7" (and again for _8).

By the way, on the subject of sources, we have an alternative way to keep track of your sources that you might consider, if you're interested. One benefit of the alternative way is that there is no limit on the number of sources. There's more information on this here: https://open-sdg.readthedocs.io/en/latest/indicator-configuration/#sources. Let me know if you would like any help with implementing that, or if it doesn't meet your needs.

Zelheim commented 11 months ago

@brockfanning Perfect! Thank you for helping with this issue! For now, I will implement a quick fix by adding extra sources within the metadata_schema.yml file, but I will see to implement what you have linked within the Open SDG documentation in the future!!

Thank you again for your help!!