search

open-sdg / sdg-build

Python package to convert SDG-related data and metadata between formats
MIT License
5 stars 23 forks source link

Show raw value in disagg report, then all languages #183

Closed brockfanning closed 3 years ago

brockfanning commented 3 years ago

Fixes https://github.com/open-sdg/open-sdg/issues/1020

This makes the translation columns optional. To turn them on, the config setting is:

docs_translate_disaggregations: true

Feature branch with docs_translate_disaggregations: true: http://sdgdev-813006012.eu-west-1.elb.amazonaws.com/data/disagg-report-show-raw-value-true/disaggregations.html

Feature branch without docs_translate_disaggregations: true: http://sdgdev-813006012.eu-west-1.elb.amazonaws.com/data/disagg-report-show-raw-value/disaggregations.html

brockfanning commented 3 years ago

@jwestw @LucyGwilliamAdmin Do you see any issues with this change? I think this is an important change for multilingual sites, where data providers may need to know which values they are allowed to put into their CSV files. With this change, data providers can use the disaggregation report as a "cheat sheet" to remind them of the allowed disaggregation values.

LucyGwilliamAdmin commented 3 years ago

So on multilingual sites there would be an extra column which would say something like data.Sex?

brockfanning commented 3 years ago

All sites, whether multilingual or not, would show an additional column that has whatever value is in the source data. Then the translated versions would be in additional columns to the right (even if only one, like on a monolingual site). I'll ping you on Slack with an example.

brockfanning commented 3 years ago

@LucyGwilliamAdmin This PR now has the optional config setting: docs_translate_disaggregations, which defaults to false.

@LucyGwilliamAdmin EDIT: Sorry I mis-typed the setting - corrected.

LucyGwilliamAdmin commented 3 years ago

@brockfanning I seem to get an error in both cases here when docs_translate_disaggregations: true: https://github.com/ONSdigital/sdg-data/runs/1588815370?check_suite_focus=true#step:5:42

brockfanning commented 3 years ago

@LucyGwilliamAdmin That looks like it had trouble downloading the GeoJSON file. You might try re-running to see if it was temporary.